fix(typing): update types to be compatible with latest mypy by Yun-Kim · Pull Request #4234 · DataDog/dd-trace-py

Yun-Kim · 2022-09-26T21:24:56Z

Description

The latest 0.981 release of mypy which our CI checks and commit hooks are dependent on resulted in previously uncaught errors. This new release of mypy includes new specifications and rules for TypeVars and abstract classes, which has been addressed in this PR.

Note: there's an ongoing issue (which I've had to ignore for now to unblock CI) with our from_env() helper in ddtrace.internal.utils.attr.py where mypy is expecting either a Type (i.e. str, float, int,...) or a Callable (i.e. formats.asbool). However, mypy mistakes the Type as a Callable and results in errors in the mypy type checking.

The current hypothesis is that since the types mentioned above are actually callables, (i.e. float(), str(), int(),...), mypy is mistaking the Type as a callable and causing the type checking error. I'm going to try to reproduce this, then if it persists create an issue on mypy to see what we can do to resolve this.

Update: created an issue on mypy. Looks like this is currently a known issue without much workaround. :(

Yun-Kim · 2022-09-26T22:43:26Z

Note: there's an issue with our from_env() helper in ddtrace.internal.utils.attr.py where mypy is expecting either a Type (i.e. str, float, int,...) or a Callable (i.e. formats.asbool). However, mypy mistakes the Type as a Callable and results in errors in the mypy type checking.

The current hypothesis is that since the types mentioned above are actually callables, (i.e. float(), str(), int(),...), mypy is mistaking the Type as a callable and causing the type checking error.

P403n1x87

Just one small change, otherwise LGTM!

P403n1x87

💪

Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI.

Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI. (cherry picked from commit 0ba3e29) # Conflicts: # ddtrace/profiling/collector/memalloc.py # ddtrace/profiling/exporter/http.py

Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI. (cherry picked from commit 0ba3e29) # Conflicts: # ddtrace/profiling/collector/__init__.py # ddtrace/profiling/collector/memalloc.py # ddtrace/profiling/exporter/http.py

Yun-Kim · 2022-10-03T21:22:21Z

@Mergifyio backport 1.5 1.4 0.61 0.x

* Initial mypy fixes for CI * Ignored mypy error with type and type constructors * Fix formatting * Fixed incorrect typing * Undo initial change Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> (cherry picked from commit 5140de4)

* Initial mypy fixes for CI * Ignored mypy error with type and type constructors * Fix formatting * Fixed incorrect typing * Undo initial change Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> (cherry picked from commit 5140de4) # Conflicts: # ddtrace/debugging/_debugger.py # ddtrace/internal/utils/cache.py # ddtrace/profiling/collector/__init__.py # ddtrace/profiling/collector/asyncio.py

mergify · 2022-10-03T21:23:36Z

backport 1.5 1.4 0.61 0.x

✅ Backports have been created

Details

#4263 fix(typing): update types to be compatible with latest mypy (backport #4234) has been created for branch 1.5
#4264 fix(typing): update types to be compatible with latest mypy (backport #4234) has been created for branch 1.4
#4265 fix(typing): update types to be compatible with latest mypy (backport #4234) has been created for branch 0.61
#4266 fix(typing): update types to be compatible with latest mypy (backport #4234) has been created for branch 0.x

* Remove ignores for updated mypy (#4253) Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI. (cherry picked from commit 0ba3e29) # Conflicts: # ddtrace/profiling/collector/memalloc.py # ddtrace/profiling/exporter/http.py * fix conflicts Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com>

…4234) (#4263) * fix(typing): update types to be compatible with latest mypy (#4234) * Initial mypy fixes for CI * Ignored mypy error with type and type constructors * Fix formatting * Fixed incorrect typing * Undo initial change Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> (cherry picked from commit 5140de4) * ci(mypy): remove type callable ignores (backport #4253) (#4258) * Remove ignores for updated mypy (#4253) Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI. (cherry picked from commit 0ba3e29) # Conflicts: # ddtrace/profiling/collector/memalloc.py # ddtrace/profiling/exporter/http.py * fix conflicts Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com>

…4234) (#4263) * fix(typing): update types to be compatible with latest mypy (#4234) * Initial mypy fixes for CI * Ignored mypy error with type and type constructors * Fix formatting * Fixed incorrect typing * Undo initial change Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> (cherry picked from commit 5140de4) * ci(mypy): remove type callable ignores (backport #4253) (#4258) * Remove ignores for updated mypy (#4253) Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI. (cherry picked from commit 0ba3e29) # Conflicts: # ddtrace/profiling/collector/memalloc.py # ddtrace/profiling/exporter/http.py * fix conflicts Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> (cherry picked from commit 026d614)

…4234) (#4263) * fix(typing): update types to be compatible with latest mypy (#4234) * Initial mypy fixes for CI * Ignored mypy error with type and type constructors * Fix formatting * Fixed incorrect typing * Undo initial change Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> (cherry picked from commit 5140de4) * ci(mypy): remove type callable ignores (backport #4253) (#4258) * Remove ignores for updated mypy (#4253) Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI. (cherry picked from commit 0ba3e29) # Conflicts: # ddtrace/profiling/collector/memalloc.py # ddtrace/profiling/exporter/http.py * fix conflicts Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> (cherry picked from commit 026d614) # Conflicts: # ddtrace/debugging/_debugger.py # ddtrace/internal/utils/cache.py # ddtrace/profiling/collector/asyncio.py

…4234) (#4263) (#4276) * fix(typing): update types to be compatible with latest mypy (#4234) * Initial mypy fixes for CI * Ignored mypy error with type and type constructors * Fix formatting * Fixed incorrect typing * Undo initial change Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> (cherry picked from commit 5140de4) * ci(mypy): remove type callable ignores (backport #4253) (#4258) * Remove ignores for updated mypy (#4253) Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI. (cherry picked from commit 0ba3e29) # Conflicts: # ddtrace/profiling/collector/memalloc.py # ddtrace/profiling/exporter/http.py * fix conflicts Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> (cherry picked from commit 026d614) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

…4234) (backport #4263) (#4278) * fix(typing): update types to be compatible with latest mypy (backport #4234) (#4263) * fix(typing): update types to be compatible with latest mypy (#4234) * Initial mypy fixes for CI * Ignored mypy error with type and type constructors * Fix formatting * Fixed incorrect typing * Undo initial change Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> (cherry picked from commit 5140de4) * ci(mypy): remove type callable ignores (backport #4253) (#4258) * Remove ignores for updated mypy (#4253) Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI. (cherry picked from commit 0ba3e29) # Conflicts: # ddtrace/profiling/collector/memalloc.py # ddtrace/profiling/exporter/http.py * fix conflicts Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Munir Abdinur <munir_abdinur@hotmail.com> (cherry picked from commit 026d614) # Conflicts: # ddtrace/debugging/_debugger.py # ddtrace/internal/utils/cache.py # ddtrace/profiling/collector/asyncio.py * Resolve merge conflicts with 0.61 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Yun Kim <yun.kim@datadoghq.com>

Initial mypy fixes for CI

bd22b4d

Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 26, 2022

Yun-Kim requested a review from a team as a code owner September 26, 2022 21:24

Ignored mypy error with type and type constructors

37788f9

Kyle-Verhoog changed the title ~~chore[ci]: Fix typing with upgraded mypy~~ chore(ci): Fix typing with upgraded mypy Sep 26, 2022

Fix formatting

490ed62

Kyle-Verhoog previously approved these changes Sep 26, 2022

View reviewed changes

Kyle-Verhoog changed the title ~~chore(ci): Fix typing with upgraded mypy~~ fix(typing): update types to be compatible with latest mypy Sep 26, 2022

Merge branch '1.x' into yunkim/mypy_check

d3d7fb5

Kyle-Verhoog reviewed Sep 26, 2022

View reviewed changes

Comment thread ddtrace/profiling/collector/__init__.py Resolved

avara1986 previously approved these changes Sep 27, 2022

View reviewed changes

P403n1x87 reviewed Sep 27, 2022

View reviewed changes

Comment thread ddtrace/internal/utils/cache.py Resolved

P403n1x87 added the manual merge Do not automatically merge label Sep 27, 2022

P403n1x87 reviewed Sep 27, 2022

View reviewed changes

Comment thread ddtrace/internal/utils/cache.py Resolved

Fixed incorrect typing

872ff13

Yun-Kim dismissed stale reviews from avara1986 and Kyle-Verhoog via 872ff13 September 27, 2022 14:05

P403n1x87 requested changes Sep 27, 2022

View reviewed changes

Comment thread ddtrace/internal/utils/cache.py Resolved

Undo initial change

1e71165

P403n1x87 approved these changes Sep 27, 2022

View reviewed changes

P403n1x87 requested review from a team, Kyle-Verhoog and avara1986 September 27, 2022 15:06

avara1986 approved these changes Sep 27, 2022

View reviewed changes

gnufede approved these changes Sep 27, 2022

View reviewed changes

brettlangdon merged commit 5140de4 into DataDog:1.x Sep 27, 2022

Yun-Kim deleted the yunkim/mypy_check branch September 27, 2022 16:12

Yun-Kim mentioned this pull request Oct 3, 2022

ci(mypy): remove type callable ignores #4253

Merged

10 of 14 tasks

mabdinur mentioned this pull request Oct 3, 2022

fix(tracing): fix error when using sqlite3 backup method (backport #4246) #4250

Merged

mergify Bot mentioned this pull request Oct 3, 2022

fix(typing): update types to be compatible with latest mypy (backport #4234) #4263

Merged

mergify Bot mentioned this pull request Oct 3, 2022

fix(typing): update types to be compatible with latest mypy (backport #4234) #4264

Closed

mergify Bot mentioned this pull request Oct 3, 2022

fix(typing): update types to be compatible with latest mypy (backport #4234) #4265

Closed

mergify Bot mentioned this pull request Oct 3, 2022

fix(typing): update types to be compatible with latest mypy (backport #4234) #4266

Closed

Navigation Menu

Repository navigation

fix(typing): update types to be compatible with latest mypy - #4234

fix(typing): update types to be compatible with latest mypy#4234
brettlangdon merged 6 commits into
DataDog:1.xfrom
Yun-Kim:yunkim/mypy_check

Yun-Kim commented Sep 26, 2022 •

edited

Loading

Uh oh!

Uh oh!

Yun-Kim commented Sep 26, 2022

Uh oh!

Uh oh!

Uh oh!

P403n1x87 left a comment

Uh oh!

Uh oh!

P403n1x87 left a comment

Uh oh!

Yun-Kim commented Oct 3, 2022

Uh oh!

mergify Bot commented Oct 3, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Yun-Kim commented Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

Yun-Kim commented Sep 26, 2022

Uh oh!

Uh oh!

Uh oh!

P403n1x87 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

P403n1x87 left a comment

Choose a reason for hiding this comment

Uh oh!

Yun-Kim commented Oct 3, 2022

Uh oh!

mergify Bot commented Oct 3, 2022

✅ Backports have been created

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Yun-Kim commented Sep 26, 2022 •

edited

Loading