Skip to content

Replace fixed colors in component's stylesheets and add scss linter. - #6458

Open
FrancescoMolinaro wants to merge 3 commits into
DSpace:mainfrom
4Science:task/main/DURACOM-529
Open

FrancescoMolinaro wants to merge 3 commits into
DSpace:mainfrom
4Science:task/main/DURACOM-529

Conversation

@FrancescoMolinaro

@FrancescoMolinaro FrancescoMolinaro commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

References

Issue: #6457

Description

Replace hardcoded colors with bootstrap or custom variables.
Add linter for scss, libraries added for the purpose:

https://www.npmjs.com/package/stylelint
https://www.npmjs.com/package/stylelint-scss
https://www.npmjs.com/package/postcss-scss

Instructions for Reviewers

There should't be any fixed color in component's stylesheets.
The new script lint:scss should list errors in case some colors are present in component's stylesheets but it should allow them in the variables stylesheets.

List of changes in this PR:

Migrated fixed colors to bootstrap or custom variables.
Added linters and utility library.
Configured script to lint files.

AI Disclosure (REQUIRED)

Per our AI Contribution Policy, all contributors to DSpace MUST disclose AI/LLM usage.
This information helps reviewers assess provenance, licensing, security, and the level of verification needed.

If AI tools were ONLY used for incidental assistance (such as spelling/grammar correction, variable auto-completion, or translation), then select 'No'.

Were AI tools used in the creation of this PR?

  • No (This PR does NOT include AI-generated or AI-assisted content that requires disclosure.)
  • Yes (This PR includes AI-generated or AI-assisted content that requires disclosure.)

If "Yes", briefly describe what portion of this PR was generated or assisted by AI. Additionally, tell us how you've verified the AI output aligns with DSpace's coding standards and is secure and accurate.

(Example: "AI assisted me in investigating the bug and generated a suggested patch. I reviewed, modified and tested the code. No AI was used for the PR description.")

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@FrancescoMolinaro FrancescoMolinaro changed the title Task/main/duracom 529 Replace fixed colors in component's stylesheets and add scss linter. Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant