Skip to content

ENH: remove notebook plugin options from pytest - #759

Draft
redeboer wants to merge 1 commit into
nbclientfrom
remove-nb-plugin-options
Draft

redeboer wants to merge 1 commit into
nbclientfrom
remove-nb-plugin-options

Conversation

@redeboer

Copy link
Copy Markdown
Member

Follow-up to #568, stacked on #757.

⚙️ Enhancements

  • When a repository has notebooks, check-dev-files now removes pytest-nbclient from its dependencies, as it already did for nbmake, so that the plugin is only installed by the nb task.
  • It also removes --nbclient*, --nbmake*, and --nbval* options from pytest's addopts. Repositories such as ComPWA/compwa.github.io and ComPWA/demo still had --nbmake there after Remove sphinx-autobuild and nbmake from environment #568 removed nbmake from their environment, so a plain pytest run required a plugin that was no longer installed. Notebooks are now run with the nb task only.

@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Oct 26, 2026
@redeboer
redeboer added this pull request to stack #760 October 26, 2026 14:19
@redeboer redeboer self-assigned this Oct 26, 2026
@redeboer
redeboer force-pushed the remove-nb-plugin-options branch from 438e364 to 9645ee9 Compare October 30, 2026 00:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ Enhancement Improvements and optimizations of existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant