Skip to content

handleMaps is ignored #31

Open
Open

Description

@martinschaef

The handleMapsBackward and handleMapsForward methods ignore the handleMaps option. It doesn't look like this option is used anywhere in the code.

Activity

  1. martinschaef commented on Sep 3, 2021

    @martinschaef
    Author

    This would do the trick:

    diff --git a/boomerangPDS/src/main/java/boomerang/WeightedBoomerang.java b/boomerangPDS/src/main/java/boomerang/WeightedBoomerang.java
    index 13088abc..cb7b7833 100644
    --- a/boomerangPDS/src/main/java/boomerang/WeightedBoomerang.java
    +++ b/boomerangPDS/src/main/java/boomerang/WeightedBoomerang.java
    @@ -178,7 +178,9 @@ public abstract class WeightedBoomerang<W extends Weight> {
                     }
                     addVisitedMethod(node.stmt().getStart().getMethod());
     
    -                handleMapsBackward(node);
    +                if (options.handleMaps()) {
    +                  handleMapsBackward(node);
    +                }
     
                     if (options.trackStaticFieldAtEntryPointToClinit()) {
                       handleStaticInitializer(node, backwardSolver);
    @@ -528,7 +530,9 @@ public abstract class WeightedBoomerang<W extends Weight> {
               }
     
               addVisitedMethod(node.stmt().getStart().getMethod());
    -          handleMapsForward(solver, node);
    +          if (options.handleMaps()) {
    +            handleMapsForward(solver, node);
    +          }
             });
     
         return solver;
    
  2. johspaeth commented on Sep 24, 2021

    @johspaeth
    Member

    Thanks for the suggested fix. I'll include the diff with my next changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions