Repository navigation
✨ Improve Design Implementation for Find in File #3
Description
We need the Find and Replace bar to look closer to Xcode's.
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
{{ message }}
We need the Find and Replace bar to look closer to Xcode's.
Activity
[-]Improve Design for Find in File[/-][+]✨ Improve Design for Find in File[/+][-]✨ Improve Design for Find in File[/-][+]✨ Improve Design Implementation for Find in File[/+]austincondiff commentedon Feb 16, 2023
Are there any standard input styles we can use for this or will we need to create this custom?
thecoolwinter commentedon Feb 17, 2023
The one in CE right now is the default
NSTextFinder, we'll need to create a custom one.luah5 commentedon Apr 11, 2023
@thecoolwinter Is it in CE, CETV or STTextView? It seems like STTextView (prove me wrong) has this file for find/replace, meaning that we need to override this in base CE (again, i might be wrong).
thecoolwinter commentedon Apr 11, 2023
The file you sent is extending STTextView to support NSTextFinder, not implementing a custom finder.
luah5 commentedon Apr 11, 2023
Ok i get it, so you're suggesting that we create a custom Find/Replace in CETV. But, considering that the find/replace is in this file in CE shouldn't the custom view be created in CE (or am i just making a incorrect point), @thecoolwinter?
thecoolwinter commentedon Apr 11, 2023
That command sends a
showFindPanelmessage down to the first active view that can respond to it. If you go into CE rn and press command F in the editor you'll get a find menu.This issue is saying the UI part for entering text to find should be custom. Because that finder view needs to be installed on the STTextView, it has to be implemented in CETV where that view can be accessed.
Merge pull request #3 from lukepistrol/main
feat: Find in Editor (#295)