Skip to content

Remember window size and position - #904

Merged
lukepistrol merged 3 commits into
CodeEditApp:mainfrom
Code-DJ:main
Jan 9, 2023
Merged

Remember window size and position#904
lukepistrol merged 3 commits into
CodeEditApp:mainfrom
Code-DJ:main

Conversation

@Code-DJ

@Code-DJ Code-DJ commented Jan 9, 2023 •
edited by lukepistrol
Loading

Copy link
Copy Markdown
Contributor

Description

Remember the window size and position across sessions.

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Screen.Recording.mp4

Closes #902

@austincondiff

austincondiff commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Will this work for multiple project windows open at once? If you can, you might post a brief screen video of this working.

@Code-DJ

Code-DJ commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

This doesn't work for multi-project windows. Will look into it. Thanks!

@austincondiff

austincondiff commented Jan 9, 2023

Copy link
Copy Markdown
Collaborator

Just to be clear, we don't currently support multiple projects in a single window. I meant each open project having its own window.

@Code-DJ
Code-DJ marked this pull request as draft January 9, 2023 18:14
@Code-DJ

Code-DJ commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

@austincondiff I did a sync fork which brought in a new commit in this PR. Is this okay - not sure if I should have done that.

@lukepistrol

lukepistrol commented Jan 9, 2023

Copy link
Copy Markdown
Member

@austincondiff I did a sync fork which brought in a new commit in this PR. Is this okay - not sure if I should have done that.

As long as your branch is still based on main and there are no conflicts arising, everything is good 👍🏻

@Code-DJ
Code-DJ marked this pull request as ready for review January 9, 2023 21:02
@Code-DJ

Code-DJ commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Added screen recording above. In hindsight, should have used the mouse to quit the app instead of cmd+Q.

lukepistrol
lukepistrol approved these changes Jan 9, 2023
View reviewed changes

@lukepistrol lukepistrol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

Wouter01
Wouter01 approved these changes Jan 9, 2023
View reviewed changes

@Wouter01 Wouter01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!

@lukepistrol
lukepistrol merged commit a46a9c4 into CodeEditApp:main Jan 9, 2023
@austincondiff

austincondiff commented Jan 9, 2023

Copy link
Copy Markdown
Collaborator

Beautiful, nice work @Code-DJ!

@allcontributors add @Code-DJ for code and bug

@allcontributors allcontributors Bot mentioned this pull request Jan 9, 2023
Merged
@allcontributors

allcontributors Bot commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

@austincondiff

I've put up a pull request to add @Code-DJ! 🎉

@austincondiff austincondiff mentioned this pull request Jan 10, 2023
Open
11 of 23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukepistrol lukepistrol lukepistrol approved these changes
@Wouter01 Wouter01 Wouter01 approved these changes
@austincondiff austincondiff Awaiting requested review from austincondiff

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐞 Remember window size and position

4 participants

@Code-DJ @austincondiff @lukepistrol @Wouter01