Skip to content

✨ Snap Sidebar To Width #856

Closed
Closed
✨ Snap Sidebar To Width#856
Assignees
yapryntsev
Labels
bugSomething isn't workingenhancementNew feature or requesttests

Description

@austincondiff
austincondiff
opened on Nov 15, 2022

Describe the solution you'd like

Snap the sidebar at a specific width. Xcode snaps to 270 we should follow suit.

When below this snapped width, the sidebar dock icons condense.

In Finder, when the sidebar snaps to a width, the user gets subtle haptic feedback to reinforce what happened.

Video Demo

Screen.Recording.2022-11-14.at.8.15.46.PM.mov

Activity

  1. austincondiff
    added
    enhancementNew feature or request
    on Nov 15, 2022
  2. austincondiff
    added
    good first issueGood for newcomers
    on Dec 17, 2022

  3. yapryntsev commented on Dec 30, 2022

    @yapryntsev
    yapryntsev
    on Dec 30, 2022
    Contributor

    I'd like to take this issue.

  4. lukepistrol
    assigned
    yapryntsev
    on Dec 30, 2022

  5. lukepistrol commented on Dec 30, 2022

    @lukepistrol
    lukepistrol
    on Dec 30, 2022
    Member

    @yapryntsev thx! Assigned it to you!

  6. yapryntsev commented on Dec 30, 2022

    @yapryntsev
    yapryntsev
    on Dec 30, 2022
    Contributor

    I need a couple of clarifications:

    1. Current implementation sets minimumThickness at 260. If we snapped at 270, the way between 270 and 260 feels slightly laggy. Should we decrease the lower boundary a bit?
    2. Currently sidebar dock icons are perfectly fit because minimumThickness is 260. Is space between icons should increase when the width is more than 270? If so, by what value does it increase?

  7. austincondiff commented on Dec 30, 2022

    @austincondiff
    austincondiff
    on Dec 30, 2022
    CollaboratorAuthor
    1. Xcode’s minimum width seems to be 242. Let’s go with that.
    2. Xcode reduces icon spacing to 9px when width is less than the snap (< 270).
      image
      When width is 270 and above the spacing is normal at 15px.
      image

    It also seems like our icons are stretch (not proportioned correctly) we may need to set the aspect ratio to fit.
    Screenshot 2022-12-30 at 10 51 49 AM

  8. austincondiff
    added a commit that references this issue on Jan 3, 2023

    Snap Sidebar To Width (#882)

    5e6cebe

  9. bombardier200 commented on Jan 5, 2023

    @bombardier200
    bombardier200
    on Jan 5, 2023
    Contributor

    @austincondiff close this issue as we merged the PR for it!

  10. austincondiff
    closed this as completedon Jan 5, 2023

  11. lukepistrol commented on Jan 11, 2023

    @lukepistrol
    lukepistrol
    on Jan 11, 2023
    Member

    @yapryntsev please have a look at the following comment regarding failing tests introduced in PR #882:

  12. lukepistrol
    reopened this on Jan 11, 2023
  13. lukepistrol
    added
    bugSomething isn't working
    tests
    and removed
    good first issueGood for newcomers
    on Jan 11, 2023
  14. austincondiff
    added this to CodeEdit Projecton Feb 14, 2023
  15. github-project-automation
    moved this to 🆕 New in CodeEdit Projecton Feb 14, 2023
  16. austincondiff
    closed this as completedon Feb 16, 2023
  17. github-project-automation
    moved this from 🆕 New to 🏁 Complete in CodeEdit Projecton Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or requesttests

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions