Repository navigation
🐞 Sidebar moved to far left #177
Description
Describe the bug
The sidebar is moved out of view.
To Reproduce
Steps to reproduce the behavior:
- Resize your window to (e.g. 800px (wide) 600px (height)
- Open a project
- Open a file in the editor
Screenshots
Desktop (please complete the following information):
- OS: 12.3 (21E230)
- Xcode: Version 13.3 (13E113)
Additional context
None.
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
Fixes CodeEditApp#177 and CodeEditApp#182
highjeans commentedon Mar 22, 2022
We might want to have the sidebar locked to a certain size.
thecoolwinter commentedon Mar 23, 2022
Looks like it might have something to do with window sizing.
Screen.Recording.2022-03-22.at.6.58.13.PM.mov
lukepistrol commentedon Mar 23, 2022
This has to do with the branch picker in the status bar which displays an error message when no git repo is available. Fixed in #193
thecoolwinter commentedon Mar 23, 2022
I had just come to the same conclusion! I was just about to make a pull request to fix it. Perfect!
thecoolwinter commentedon Mar 23, 2022
Actually, don't close this quite yet. The problem is being caused by the
.fixedSize()modifier inStatusBarBranchPicker. Since that has a fixed size, SwiftUI can't compress it when it needs to shrink the window. Just in case someone has a long branch name that should be changed to.fixedSize(horizontal: false, vertical: true). I'll make a PR for that now.RayZhao1998 commentedon Mar 23, 2022
@thecoolwinter I don't think changing from
.fixedSize()to.fixedSize(horizontal:false, vertical: true)is a right solution. It'll make theStatusBarBranchPickertake up extra space.RayZhao1998 commentedon Mar 23, 2022
open another issue #209
thecoolwinter commentedon Mar 23, 2022
I agree but we could also add a Spacer with min width 0 and it would fix this problem. Having the
falsevalue for the horizontal makes it so we can know that SwiftUI will shrink this specific component rather than another one or not shrink it at all.[-][BUG] - Sidebar moved to far left[/-][+]🐞 Sidebar moved to far left[/+]Update Text Container Width Correctly (CodeEditApp#177)