Repository navigation
🐞 Compile errors by SwiftLintPlugin #1267
Description
Description
When trying to compile the current sources with XCode 14.3 on macOS 13.3.1(a) I get the following compilation error:
.../CodeEditLanguages/Tests/CodeEditLanguagesTests/CodeEditLanguagesTests.swift:12:1 Usage of // swiftlint:disable all is prohibited
.../CodeEditTextView/Tests/CodeEditTextViewTests/CodeEditTextViewTests.swift:4:1 Usage of // swiftlint:disable all is prohibited
.../CodeEditTextView/Tests/CodeEditTextViewTests/STTextViewControllerTests.swift:7:1 Usage of // swiftlint:disable all is prohibited
The issues are raised by the packages CodeEditLanguages and CodeEditTextView. The cause is the latest update of SwiftLintPlugin from v0.2.2 to v0.2.3. This update updated SwiftLint from v0.50 to v0.51 which introduced stricter rules on blanket disable commands.
Disabling all SwiftLint checks is no longer supported. Only the necessary lint issues should be disabled.
To Reproduce
- Download a fresh clone of the repo
- Open the project in XCode and build it
Expected Behavior
No compiler/lint errors
Version Information
CodeEdit: Current repo state
macOS: 13.3.1(a)
Xcode: 14.3
Additional Context
No response
Screenshots
Activity
LostInCompilation commentedon May 14, 2023
For
CodeEditLanguagesI cannot find// swiftlint:disable allin the file anymore:https://github.com/CodeEditApp/CodeEditLanguages/blob/9e7b7c479fdb405910161e5002e137a1a88362a1/Tests/CodeEditLanguagesTests/CodeEditLanguagesTests.swift
Seems like an update to 0.1.14 should solve the issue for this package.
In
CodeEditTextViewthe swiftlint lines are still present.FastestMolasses commentedon Jul 24, 2023
I believe this should be closed now