Repository navigation
New Cargo Feature requires Cargo.toml files update #1349
Description
Describe the bug
Any Cargo or make command fails with Error feature 'resolver' is required
To Reproduce
Steps to reproduce the behavior:
Fresh Development Installation with branch main updated
$ git log -1
commit 356757e2c776132e4c8db0a85e4b1733137330fd (HEAD -> main, origin/main, origin/HEAD)
Author: noot <36753753+noot@users.noreply.github.com>
Date: Fri Dec 17 20:03:29 2021 -0500
drand v14 update: fix fetching around null tipsets (#1339)
running make release or cargo clean
Log output
$ make release
cargo build --release --bin forest
error: failed to parse manifest at `/absolute/path/to/forest/Cargo.toml`
Caused by:
feature `resolver` is required
consider adding `cargo-features = ["resolver"]` to the manifest
make: *** [Makefile:55: release] Error 101
$ cargo clean
error: failed to parse manifest at `/absolute/path/to/forest/Cargo.toml`
Caused by:
feature `resolver` is required
consider adding `cargo-features = ["resolver"]` to the manifest
Expected behaviour
should compile normally
Environment (please complete the following information):
- OS:
$ uname -a
Linux thebrain 5.10.0-10-amd64 #1 SMP Debian 5.10.84-1 (2021-12-08) x86_64 GNU/Linux
- Rust version(e.g.
rustc --version)
$ rustc --version
rustc 1.48.0
$ cargo --version
cargo 1.46.0
- Branch/commit
$ git log -1
commit 356757e2c776132e4c8db0a85e4b1733137330fd (HEAD -> main, origin/main, origin/HEAD)
Author: noot <36753753+noot@users.noreply.github.com>
Date: Fri Dec 17 20:03:29 2021 -0500
drand v14 update: fix fetching around null tipsets (#1339)
Other information and links
Activity
bodo-hugo-barwich commentedon Jan 6, 2022
Actually modifying the
Cargo.tomlas described in the Cargo Meta Tracker does solve this issue.but it needs to be done to all
Cargo.tomlfileselmattic commentedon Jan 6, 2022
Hey Bodo, have you tried to build with last version?
(run
rustup update stableto upgrade cargo and rustc to 1.57.0)truemagic-coder commentedon Jan 8, 2022
FYI it works on Ubuntu 20.04 (latest) with Rust 1.57.0 (stable). Make release created the release and cargo clean did not error.
Using Ubuntu 20.04 (latest) with Rust 1.48.0 (stable). The same error happened to me as Bodo. I had to delete the rust-toolchain file (denoting stable) in the git repo to override 1.57.0 to 1.48.0. The documentation for forest can be updated with the
rustup update stablecommand. Would you like me to submit a PR to the README?I know this is a new issue but I also tried building the Docker image and that did not work. Do you want me to create a new issue in the tracker?
Compiling forest_libp2p v0.1.0 (/usr/src/forest/node/forest_libp2p)
error: git describe failed with status 128: fatal: not a git repository (or any of the parent directories): .git
--> node/forest_libp2p/src/behaviour.rs:59:47
|
59 | static ref CURRENT_COMMIT: &'static str = git_version!();
| ^^^^^^^^^^^^^^
|
= note: this error originates in the macro
proc_macro_call(in Nightly builds, run with -Z macro-backtrace for more info)Compiling genesis v0.1.0 (/usr/src/forest/utils/genesis)
error: could not compile
forest_libp2pdue to previous errorwarning: build failed, waiting for other jobs to finish...
error: failed to compile
forest v0.1.0 (/usr/src/forest/forest), intermediate artifacts can be found at/usr/src/forest/targetbodo-hugo-barwich commentedon Jan 8, 2022
The error that I was observing is reproducible as seen in this test workflow
Rust Compiler Matrix Test
It seems especially applicable to the Rust Versions
< 1.52.0as it can be concluded from thecargocommit history.But I noticed that it does not only affect this project but several libraries that use this feature.
Also I saw that the Minimum Rust Version for the project was incremented to
1.55.So, this issue is actually not applicable to the project.
bodo-hugo-barwich commentedon Jan 16, 2022
According to the Test Matrix the earliest working Rust compiler version is
1.53.0Rust Compiler Test Matrix