[vedanth-jadhav]

Problem

If preview playback is rejected while trimming, the recorder keeps running and its safety timer can later publish a partial video. Recorder errors and unexpected stops can also leave the trimmer stuck or publish incomplete output. The canvas capture track is retained after a successful trim.

Changes

• Stop and discard failed or cancelled recordings, release the canvas capture track, and clear the frame callback and timeout.
• Report playback, recorder, and timeout failures instead of offering partial output. Allow retry after a failure.
• Cancel an active trim when switching files or leaving the page, without stopping the preview's audio destination track.

Validation

• 11 focused tests pass, including eight mounted trimmer cases and three existing speed-controller cases. Playback rejection, recorder error, and canvas-track cleanup cases fail against main.
• Tested together with fix(web): keep the audio in every trim, not just the first #3433: all 10 trimmer and audio cases pass in a combined checkout. Its fake stream was extended with getVideoTracks() to match the browser API used here.
• Scoped strict TypeScript check of the component and tests with lightweight UI and analytics declarations; workflow YAML and diff checks pass. Biome reports the same 13 errors and five warnings already present in the component on main; the new test is clean.

Tests use media API stand-ins; a full web build and physical capture were not run.

Confidence Score: 5/5

The PR appears safe to merge, with the previous coverage gap addressed.

Summary

The PR stops failed or cancelled trims, releases canvas capture tracks, and prevents partial downloads.

• Video trims discard failed recordings and clean up capture resources.

_{Reviews (2) · Last reviewed commit: "Test trimmer timeout cleanup" · Reviewed by Greptile}

[vercel]

Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

[greptile-apps]

Timeout failures lack coverage

The new tests never exercise the timeout that now rejects a stalled trim instead of publishing partial output. A regression could bring back partial downloads without failing these tests.

Add a fake-timer test that advances past the deadline and checks the error, recorder shutdown, canvas-track cleanup, and absence of an output URL. Also check that a late stop event cannot publish the failed recording.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/web/__tests__/unit/trimming-tool-recording-failure.test.ts
Line: 134-142

Comment:
**Timeout failures lack coverage**

The new tests never exercise the timeout that now rejects a stalled trim instead of publishing partial output. A regression could bring back partial downloads without failing these tests.

Add a fake-timer test that advances past the deadline and checks the error, recorder shutdown, canvas-track cleanup, and absence of an output URL. Also check that a late stop event cannot publish the failed recording.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[vedanth-jadhav]

Addressed in e734fea: the new fake-timer regression advances past the timeout and checks the error, recorder shutdown, canvas-track cleanup, absence of an output URL, and a late stop callback.

[vedanth-jadhav]

@greptile review