Repository navigation
Fix caption translation request ownership - #3469
Open
vedanth-jadhav wants to merge 1 commit into
Open
vedanth-jadhav wants to merge 1 commit into
vedanth-jadhav wants to merge 1 commit into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Caption translation starts the server action inside a React state updater. Under Strict Mode two simultaneous requests for the same language can trigger four translation calls; concurrent languages also clear the loading indicator as soon as the first request finishes. A rejected server action leaves its caller's promise unresolved, and a late result for one video can populate the next video's caption cache.
Changes
nullso callers can retry, and cache successful translations synchronously.Validation
The tests mock the translation server actions; they do not exercise a live AI provider or a full web build.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
This PR moves caption translation requests out of React state updaters and keeps each video's caption state separate.
No actionable issues were found. Tests were inspected, not run during this review.
Reviews (1) · Last reviewed commit: "Fix caption translation request ownershi..." · Reviewed by Greptile