Repository navigation
fix(web): fall back when the Mac architecture hint is unknown - #3468
Open
vedanth-jadhav wants to merge 1 commit into
Open
vedanth-jadhav wants to merge 1 commit into
vedanth-jadhav wants to merge 1 commit into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The download page treats every architecture hint except
armandarm64as Intel. If a browser returns an empty or unknown high-entropy architecture value, an Apple Silicon Mac can be sent to the Intel installer even when WebGL identifies an Apple GPU.Recognize known ARM and x86 values explicitly and use the existing WebGL/default fallback for missing or unrecognized hints. This applies to the download page and other download links using the same hook. The fallback remains heuristic: when the browser provides neither architecture nor a usable renderer, the existing Apple Silicon default remains.
Validation: 15 focused tests pass. Thirteen mounted hook/link cases cover empty and unknown hints, Apple and Intel WebGL fallbacks, known architectures, unavailable hints, Windows and Linux; five fail on main 97c8d63 and eight controls pass. Two existing platform-download tests pass. Scoped strict TypeScript/noUncheckedIndexedAccess, Biome, CI YAML parsing and git diff --check pass. These are controlled browser API tests; no physical Mac, full web build or full web typecheck was run. No dependencies or public APIs changed.


Confidence Score: 5/5
The PR appears safe to merge.Summary
useDetectPlatformnow recognizes known ARM and x86 hints explicitly. Empty or unknown hints reach the existing WebGL fallback.Reviews (1) · Last reviewed commit: "fix(web): handle unknown Mac architectur..." · Reviewed by Greptile