Skip to content

fix(web): fall back when the Mac architecture hint is unknown - #3468

Open
vedanth-jadhav wants to merge 1 commit into
CapSoftware:mainfrom
vedanth-jadhav:fix/web-download-unknown-architecture
Open

vedanth-jadhav wants to merge 1 commit into
CapSoftware:mainfrom
vedanth-jadhav:fix/web-download-unknown-architecture

Conversation

@vedanth-jadhav

@vedanth-jadhav vedanth-jadhav commented Oct 27, 2026 •

Copy link
Copy Markdown

The download page treats every architecture hint except arm and arm64 as Intel. If a browser returns an empty or unknown high-entropy architecture value, an Apple Silicon Mac can be sent to the Intel installer even when WebGL identifies an Apple GPU.

Recognize known ARM and x86 values explicitly and use the existing WebGL/default fallback for missing or unrecognized hints. This applies to the download page and other download links using the same hook. The fallback remains heuristic: when the browser provides neither architecture nor a usable renderer, the existing Apple Silicon default remains.

Validation: 15 focused tests pass. Thirteen mounted hook/link cases cover empty and unknown hints, Apple and Intel WebGL fallbacks, known architectures, unavailable hints, Windows and Linux; five fail on main 97c8d63 and eight controls pass. Two existing platform-download tests pass. Scoped strict TypeScript/noUncheckedIndexedAccess, Biome, CI YAML parsing and git diff --check pass. These are controlled browser API tests; no physical Mac, full web build or full web typecheck was run. No dependencies or public APIs changed.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

useDetectPlatform now recognizes known ARM and x86 hints explicitly. Empty or unknown hints reach the existing WebGL fallback.

  • Mac download links use fallbacks for unknown architecture hints.

Reviews (1) · Last reviewed commit: "fix(web): handle unknown Mac architectur..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant