Repository navigation
fix(web): preserve the newest recorder device list - #3467
Open
vedanth-jadhav wants to merge 1 commit into
Open
vedanth-jadhav wants to merge 1 commit into
vedanth-jadhav wants to merge 1 commit into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recorder's camera and microphone hooks can issue overlapping
enumerateDevices()calls when permissions change or devices are connected. An older response can arrive last and replace the newer device list, hiding a newly available device or showing one that was removed. A pending response can also update the list after the dialog closes.Track each hook's newest request and invalidate pending work on close or unmount. The existing device filtering, explicit refresh and device-change subscription remain in place for both the dashboard recorder and comment recorders.
Validation: 20 focused tests pass. Eight mounted hook tests cover reversed device-change results, a pre-permission response arriving after refresh, closing during enumeration, filtering and listener cleanup for both device types; six regressions fail on main 97c8d63 and two controls pass. The existing comment-recorder and media-recorder setup tests also pass. Scoped strict TypeScript/noUncheckedIndexedAccess, Biome, CI YAML parsing and git diff --check pass. No physical camera/microphone or full web build/typecheck was run.


Confidence Score: 5/5
The PR appears safe to merge.Summary
Both recorder hooks now keep only the newest device-list response and ignore pending responses after close or unmount.
Reviews (1) · Last reviewed commit: "fix(web): keep the newest recorder devic..." · Reviewed by Greptile