Skip to content

fix(web): preserve the newest recorder device list - #3467

Open
vedanth-jadhav wants to merge 1 commit into
CapSoftware:mainfrom
vedanth-jadhav:fix/web-device-enumeration-order
Open

vedanth-jadhav wants to merge 1 commit into
CapSoftware:mainfrom
vedanth-jadhav:fix/web-device-enumeration-order

Conversation

@vedanth-jadhav

@vedanth-jadhav vedanth-jadhav commented Oct 27, 2026 •

Copy link
Copy Markdown

The recorder's camera and microphone hooks can issue overlapping enumerateDevices() calls when permissions change or devices are connected. An older response can arrive last and replace the newer device list, hiding a newly available device or showing one that was removed. A pending response can also update the list after the dialog closes.

Track each hook's newest request and invalidate pending work on close or unmount. The existing device filtering, explicit refresh and device-change subscription remain in place for both the dashboard recorder and comment recorders.

Validation: 20 focused tests pass. Eight mounted hook tests cover reversed device-change results, a pre-permission response arriving after refresh, closing during enumeration, filtering and listener cleanup for both device types; six regressions fail on main 97c8d63 and two controls pass. The existing comment-recorder and media-recorder setup tests also pass. Scoped strict TypeScript/noUncheckedIndexedAccess, Biome, CI YAML parsing and git diff --check pass. No physical camera/microphone or full web build/typecheck was run.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Both recorder hooks now keep only the newest device-list response and ignore pending responses after close or unmount.

  • Recorder device lists keep the newest camera and microphone results.

Reviews (1) · Last reviewed commit: "fix(web): keep the newest recorder devic..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant