Skip to content

fix(cli): upload automation recordings to the selected team - #3458

Open
AksharP5 wants to merge 1 commit into
CapSoftware:mainfrom
AksharP5:automation-upload-org
Open

AksharP5 wants to merge 1 commit into
CapSoftware:mainfrom
AksharP5:automation-upload-org

Conversation

@AksharP5

@AksharP5 AksharP5 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

An Upload automation could send a CLI recording to the wrong team because the CLI discarded the rule's selected organization. The account's default or active destination won instead.

Pass that selection through the existing uploader to both creation APIs: orgId for desktop sessions and organizationId for CLI API keys. Unconfigured destinations keep the existing server selection.

Closes #3457

Same Upload rule Before After
Organization B selected; account default is A Uploader receives no destination; server selects A Uploader receives B; both request formats include it
No organization selected Destination omitted Destination omitted

The actual CLI method reproduces the dropped argument on baseline 97c8d634; the same probe passes after the fix. Three focused upload tests also pass, including actual local HTTP request capture for desktop sessions and JSON payload assertions for API-key uploads.

Formatting and whitespace checks pass. Full local CLI compilation stops at missing pkg-config/OpenSSL development dependencies. Verification uses production method bodies and recording metadata IO with credential/upload fixtures; no native capture or live upload ran. Independent GPT-6 Astra high review passed on 36a6c00d681b4d08f14d28a6ef1f79221120b4a6. Its broader 11-test harness uses the actual automation engine, upload routing and request builders against loopback HTTP, and covers credential precedence/fallback, destination omission, URL encoding, direct-upload defaults, metadata and existing-link reuse. Scoped strict Clippy also passes.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

The CLI now passes an Upload rule’s selected team through both upload request formats.

  • CLI automation uploads now keep the rule’s selected organization.

No actionable issues found. Review checks were source-based; no builds, tests, or live uploads were run.

Reviews (1) · Last reviewed commit: "fix(cli): honor upload automation organi..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI upload automations ignore the selected destination organization

1 participant