Repository navigation
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Upload automation could send a CLI recording to the wrong team because the CLI discarded the rule's selected organization. The account's default or active destination won instead.
Pass that selection through the existing uploader to both creation APIs:
orgIdfor desktop sessions andorganizationIdfor CLI API keys. Unconfigured destinations keep the existing server selection.Closes #3457
The actual CLI method reproduces the dropped argument on baseline
97c8d634; the same probe passes after the fix. Three focused upload tests also pass, including actual local HTTP request capture for desktop sessions and JSON payload assertions for API-key uploads.Formatting and whitespace checks pass. Full local CLI compilation stops at missing pkg-config/OpenSSL development dependencies. Verification uses production method bodies and recording metadata IO with credential/upload fixtures; no native capture or live upload ran. Independent GPT-6 Astra high review passed on
36a6c00d681b4d08f14d28a6ef1f79221120b4a6. Its broader 11-test harness uses the actual automation engine, upload routing and request builders against loopback HTTP, and covers credential precedence/fallback, destination omission, URL encoding, direct-upload defaults, metadata and existing-link reuse. Scoped strict Clippy also passes.

Confidence Score: 5/5
The PR appears safe to merge.Summary
The CLI now passes an Upload rule’s selected team through both upload request formats.
No actionable issues found. Review checks were source-based; no builds, tests, or live uploads were run.
Reviews (1) · Last reviewed commit: "fix(cli): honor upload automation organi..." · Reviewed by Greptile