feat(desktop-gpui): resize a picked window to a ratio or size, and focus it to record it alone by richiemcilroy · Pull Request #3454 · CapSoftware/Cap

richiemcilroy · 2026-10-27T03:11:55Z

Stacked on #3452.

Problem

In the window picker, the picked window's size was plain text, and the only way to change the shape of what gets recorded was to resize the window by hand. A window recording also captured a region of the screen. #3452 adds the option to record the window by itself, but nothing in the app could turn it on.

Change

Size chip. The size readout becomes a chip. It shows the size the window will record at (pixels, so 1440 × 900 points reads 2880 × 1800 on a Retina display) and its ratio when it matches one. It opens a menu:
- Ratios: 21:9, 16:9, 16:10, 4:3, 1:1 and 9:16. A ratio keeps the window's area and centre, grows a tiny window to at least 160 pt on its shorter side, and keeps it at least 16 pt inside the display's usable area (menu bar, Dock and taskbar excluded).
- Sizes: 720p, 1080p, 1440p and 4K in recorded pixels, listed only when they fit.
- The current ratio or size is ticked.
Focus toggle. Focus centres the window in the usable area, brings it to the front, and records it by itself. Turning it off puts the window back where the picker found it.
- Focus lives in the picker's shared state, so every display's overlay shows the choice the recording will use.
- Picking a window while Focus is on centres and raises it, as turning Focus on does.
- In Instant mode with a camera, macOS and Windows keep recording the screen region, because the camera bubble reaches the video through the screen capture (feat(recording): capture a window by itself, on request, on macOS and Windows #3452). The Focus tooltip says so.
Window capture style setting. Focus is the same stored choice as a new Settings › General › Window capture style row: Screen region (the default, today's behaviour) or Focused window. The last choice is remembered. Recording reads it as it starts.
Moving the window. foreign_window does the platform work:
- macOS: the Accessibility API (AXPosition/AXSize, matched to the window through _AXUIElementGetWindow), which Cap already holds the permission for.
- Windows: SetWindowPos, adding back DWM's invisible resize borders and restoring a maximized window first. The maximized window's WINDOWPLACEMENT is saved, so putting it back maximizes it again with its old restore size.
- X11: _NET_MOVERESIZE_WINDOW and _NET_ACTIVE_WINDOW.
- Wayland: cannot move other apps' windows, so the chip stays read-only with a tooltip saying so and Focus is hidden. The same happens on macOS without Accessibility.
Off the UI thread, in order. Moves and restores run on one worker thread, in the order they were asked for, because SetWindowPos waits on the target app. So a cancel's restore always lands after a move the user started first. The highlight then animates to wherever the app actually put the window, since apps clamp to their own minimum sizes or cell grids. A move that finishes after the user has picked another window, or closed the picker, leaves the new choice alone.
The menu holds its window. Opening the size menu pins the window it acts on, so passing over another app on the way to a row cannot change the target.
Highlight tracking. The pinned window's bounds are now re-read on every picker poll. Before, the highlight stayed where the window was first picked.
Restoring. Dismissing the picker puts back every window it moved. Starting a recording keeps them where they were shaped.

The new overlay strings are literals, like the rest of the overlay on this base. #3423 localizes the overlay, and they move into its catalogue when this rebases onto it. The settings row and options are localized in all seven catalogues.

Test

Unit tests (window_arrange, and foreign_window's ordering of queued jobs):
- ratio keeps area and centre;
- every ratio near every edge stays on screen;
- tiny windows grow;
- exact sizes fit or are refused on 1x and 2x displays;
- centring;
- ratio detection.
i18n: the i18n surface tests pin the new keys, and cap-i18n-build passes.
Real app: Picker smoke (real app) now drives a real window on macOS, Windows and Linux X11 through the overlay's own menu and toggle. It picks the window it opened (TextEdit, Notepad or xterm) outright, so the runner's cursor position doesn't matter:
1. chooses 16:9, then checks the actual frame is within 4% of 16:9 and inside the display;
2. turns Focus on, then checks the window is centred;
3. dismisses the picker, then checks the window is back within 6 pt of where it started.
Screenshots of each step are uploaded.

Confidence Score: 5/5

The PR appears safe to merge, with a non-blocking gap in feedback when Start times out.

Findings

Start hides its retry message ▶

Fix with agent prompt

### Issue 1
apps/desktop-gpui/src/app_windows.rs:2482-2489
When a window move takes more than five seconds, Start stops and saves the retry message in `session.error`. The picker stays open, but only the hidden main window shows that error. The user sees neither a recording nor an explanation until they close the picker.

Show the error in the picker, or reveal the main window when Start times out.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR adds window resizing and Focus controls to the picker, plus a saved window capture setting.

The picker lets people choose a window size or shape.
Focus centers the picked window and can record it by itself.
The picker moves picked windows and restores them when it closes.

_{Reviews (8) · Last reviewed commit: "fix(desktop-gpui): tie a waiting Start t..." · Reviewed by Greptile}

…cus it to record it alone

vercel · 2026-10-27T03:12:13Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
cap-status	Ready	Preview	Oct 28, 2026 2:18am UTC

richiemcilroy · 2026-10-27T03:49:02Z

hey @greptileai, please re-review the PR

# Conflicts: # apps/desktop-gpui/src/picker_probe.rs

… pin the size menu's window, ignore stale moves, restore maximized windows

# Conflicts: # apps/desktop-gpui/src/picker_probe.rs

richiemcilroy · 2026-10-27T04:14:25Z

hey @greptileai, please re-review the PR

…he smoke's test window outright

richiemcilroy · 2026-10-27T06:22:23Z

hey @greptileai, please re-review the PR

…gion, and spawn the restore

richiemcilroy · 2026-10-27T07:08:27Z

hey @greptileai, please re-review the PR

capy-ai

Capy found no issues.

capy-ai

Capy found no issues.

capy-ai

Capy found no issues.

… put moved windows back on every non-recording exit

capy-ai

Capy found 1 potential issue (1 medium).

View 1 other finding in Capy.

capy-ai · 2026-10-27T22:50:59Z

+        let limit = cx.background_executor().timer(ARRANGE_SETTLE_LIMIT);
+        futures_util::future::select(std::pin::pin!(settled), std::pin::pin!(limit)).await;
+        cx.update(|cx| {
+            if !cx.global::<AppWindows>().overlays.is_empty() {


Deferred overlay Start can fire against a re-armed picker

Medium Severity

With arranged windows pending, start_recording_from_overlay defers the start until in_order(|| ()) drains or ARRANGE_SETTLE_LIMIT (1500 ms) fires, and the overlay stays open and interactive the whole time: the Record click (target_overlay.rs:1252) only defers, and only start_recording_from_overlay_now closes it. If the user presses Escape (dismiss_target_overlays restores window A, closes the overlays) and re-picks window B within that window — likeliest when a hung target app forces the full 1500 ms — the deferred task's only revalidation is !cx.global::<AppWindows>().overlays.is_empty(), true again because of B's overlay. start_recording_from_overlay_now(target, cx) then runs with the click-time ScreenCaptureTarget for A: keep_arranged_windows drains B's arranged entry and discards its original, permanently leaving B's window moved, B's overlays are force-closed, and a recording of cancelled target A starts (A's own put_back is still queued behind the stuck move, so A's bounds may be read mid-restore). The gate must verify the same picker/target is still armed, or dismiss/arm must cancel a pending deferred start.

richiemcilroy · 2026-10-27T23:39:19Z

@greptileai

greptile-apps · 2026-10-27T23:44:57Z

+        cx.update(|cx| {
+            if !cx.global::<AppWindows>().overlays.is_empty() {
+                start_recording_from_overlay_now(target, cx);


Cancelled Start can resume

While a slow window move holds the queue, the user can press Start, dismiss the picker, and reopen it for another window. After the wait, this check accepts any open overlay and starts the old target, recording the window the user cancelled.

Tie the pending Start to the picker that requested it, and invalidate it on dismissal.

Knowledge Base Used: GPUI desktop client

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/desktop-gpui/src/app_windows.rs Line: 2454-2456 Comment: **Cancelled Start can resume** While a slow window move holds the queue, the user can press Start, dismiss the picker, and reopen it for another window. After the wait, this check accepts any open overlay and starts the old `target`, recording the window the user cancelled. Tie the pending Start to the picker that requested it, and invalidate it on dismissal. **Knowledge Base Used:** [GPUI desktop client](https://app.greptile.com/cap/-/custom-context/knowledge-base/capsoftware/cap/-/docs/gpui-desktop-client.md) --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-10-27T23:44:57Z

    {
        return;
    }
+    keep_arranged_windows(cx);


Cancelled starts leave windows changed

keep_arranged_windows forgets the original frames before recording checks finish. For example, cancelling the low-storage prompt after pressing Start leaves every resized or focused window changed, even though no recording started. Users must put those windows back by hand.

Keep the saved frames through these checks and restore them on cancellation. Discard them only when capture commits to starting.

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/desktop-gpui/src/app_windows.rs Line: 2472 Comment: **Cancelled starts leave windows changed** `keep_arranged_windows` forgets the original frames before recording checks finish. For example, cancelling the low-storage prompt after pressing Start leaves every resized or focused window changed, even though no recording started. Users must put those windows back by hand. Keep the saved frames through these checks and restore them on cancellation. Discard them only when capture commits to starting. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

…ows still moving, keep moved windows until recording commits

capy-ai

Capy found 1 potential issue (1 medium).

View 2 other findings in Capy.

capy-ai · 2026-10-28T02:00:04Z

+        );
+        cx.update(|cx| {
+            let current = overlay_handles(cx);
+            if current.is_empty() || current != overlays {


Deferred Start records the click-time target after the pick changes

Medium Severity

The deferred Start captured target from the picker's selection at click time (target_overlay.rs start_recording), but the revalidation at app_windows.rs:2479 only compares overlay-window identity, and the new comment's claim that opening a new picker drops the Start does not hold for a same-mode re-open. While the settle wait runs (up to 5 s with the new limit), the picker stays interactive: a click on another window re-pins through the overlay's click-anywhere-to-select (pin_hovered), and a same-mode re-arm (tray item, hotkey) goes through open_overlays_core/reopens_overlays (app_windows.rs:1951), which keeps the identical overlay windows when the armed mode already matches, so current == overlays passes. The deferred task then calls start_recording_from_overlay_now with the stale target: it force-closes the picker that now presents window B and records window A; keep_arranged_windows at app_windows.rs:4015 then drains every arranged entry including B's saved original, so a B the user resized after the click is left moved with nothing to put it back. Bind the waiting Start to the picked target — compare the click-time target/pinned window against TargetSelect's current one and drop when it moved — not just to the overlay set.

richiemcilroy · 2026-10-28T02:11:29Z

@greptileai

greptile-apps · 2026-10-28T02:15:32Z

+            if !settled {
+                tracing::warn!("a picked window is still moving; recording not started");
+                RecordingSession::global(cx).update(cx, |session, cx| {
+                    session.error =
+                        Some("The window is still being resized. Try starting again.".into());
+                    cx.notify();
+                });
+                return;


Start hides its retry message

When a window move takes more than five seconds, Start stops and saves the retry message in session.error. The picker stays open, but only the hidden main window shows that error. The user sees neither a recording nor an explanation until they close the picker.

Show the error in the picker, or reveal the main window when Start times out.

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/desktop-gpui/src/app_windows.rs Line: 2482-2489 Comment: **Start hides its retry message** When a window move takes more than five seconds, Start stops and saves the retry message in `session.error`. The picker stays open, but only the hidden main window shows that error. The user sees neither a recording nor an explanation until they close the picker. Show the error in the picker, or reveal the main window when Start times out. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

…rt gives up on a moving window

superagent-security

Superagent found 1 security concern(s).

superagent-security · 2026-10-28T02:19:12Z

          now=$(date +%s)
          for client in "$app" /bin/bash /Users/runner/bin/Runner.Worker /Users/runner/bin/Runner.Listener; do
-            sudo sqlite3 "$db" "INSERT OR REPLACE INTO access (service,client,client_type,auth_value,auth_reason,auth_version,indirect_object_identifier,flags,last_modified) VALUES ('kTCCServiceScreenCapture','$client',1,2,4,1,'UNUSED',0,$now);"
+            for service in kTCCServiceScreenCapture kTCCServiceAccessibility; do


P2: macOS picker smoke grants Accessibility TCC to runner processes used by fork-PR code

New loop grants Accessibility TCC to /bin/bash and runner worker processes used by untrusted fork-PR builds.

Grant Accessibility only to the built app, or prevent fork PRs from running this self-hosted smoke with the grant.

AI prompt

Check if this security scanner issue is valid. If so, understand the root cause and fix it. If appropriate, update or add tests. Keep the change focused and preserve intended behavior. <file name=".github/workflows/picker-smoke.yml"> <violation number="1" location=".github/workflows/picker-smoke.yml:141"> <priority>P2</priority> <title>macOS picker smoke grants Accessibility TCC to runner processes used by fork-PR code</title> <evidence>The permission step previously inserted only `kTCCServiceScreenCapture` for the built app, `/bin/bash`, `Runner.Worker`, and `Runner.Listener`. The changed loop now inserts both `kTCCServiceScreenCapture` and `kTCCServiceAccessibility` for the same clients. This workflow is triggered by `pull_request` and, for fork PRs that touch `apps/desktop-gpui/src/**`, runs the PR-built binary and PR-controlled `scripts/setup.js`/`scripts/picker-smoke/run.sh` on Blacksmith macOS runners. Granting Accessibility to `/bin/bash` and the runner worker processes means any later shell step can use macOS UI automation, read other applications' accessibility trees, and synthesize input without an additional prompt. That is broader than the pre-existing screen-capture grant.</evidence> <recommendation>Do not grant `kTCCServiceAccessibility` to `/bin/bash`, `Runner.Worker`, or `Runner.Listener`. Grant it only to the specific built binary, ideally only after the build has been reviewed, or restrict this workflow to same-repository PRs/trusted branches. If the smoke must run on fork PRs, use an ephemeral runner account that has no access to other applications or credentials and explicitly reset the TCC grant after the job.</recommendation> </violation> </file>

This grant does not widen what PR code can do on that runner. The Blacksmith macOS runner is a single-use VM, and the same job already runs with passwordless sudo (this very step writes TCC.db with it), so code from a fork PR could grant itself any TCC service anyway. Accessibility is needed because the smoke moves another app's window through the AX API, and macOS checks that against the responsible process (the runner that launches cap-gpui), not the binary alone; granting it to the app only would make the window-arrangement check fail.

The developer’s explanation addresses the core concern: the Blacksmith runner is a single-use VM, so the TCC grant is not persistent, and the same job already runs with passwordless sudo—meaning untrusted code could already modify TCC.db directly. Additionally, the Accessibility grant to the runner processes is technically required because macOS applies the AX permission check to the responsible process launching the app, not the built binary alone, so restricting the grant to the app would break the smoke test. No additional exposure is introduced by this change.

capy-ai

Capy found no issues.

View 1 other finding in Capy.

feat(desktop-gpui): resize a picked window to a ratio or size, and fo…

26d1cb8

…cus it to record it alone

vercel Bot deployed to Preview – cap-status October 27, 2026 03:12

View deployment

vercel Bot deployed to Preview – cap-web October 27, 2026 03:13

View deployment

richiemcilroy added 2 commits October 27, 2026 03:38

Merge feat/recording-window-only into feat/gpui-window-arrange-focus

981d474

refactor(desktop-gpui): drop the unused forget_arranged

22eead8

vercel Bot deployed to Preview – cap-status October 27, 2026 03:38

View deployment

vercel Bot deployed to Preview – cap-web October 27, 2026 03:40

View deployment

richiemcilroy mentioned this pull request Oct 27, 2026

feat(desktop-gpui): picker controls in Cap Glass #3456

Open

greptile-apps Bot mentioned this pull request Oct 27, 2026

feat(recording): capture a window by itself, on request, on macOS and Windows #3452

Merged

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

richiemcilroy added 2 commits October 27, 2026 04:02

Merge feat/recording-window-only into feat/gpui-window-arrange-focus

842bcde

# Conflicts: # apps/desktop-gpui/src/picker_probe.rs

fix(desktop-gpui): share Focus across overlays and apply it to picks,…

8ebbe51

… pin the size menu's window, ignore stale moves, restore maximized windows

vercel Bot deployed to Preview – cap-status October 27, 2026 04:06

View deployment

vercel Bot deployed to Preview – cap-web October 27, 2026 04:07

View deployment

Merge feat/recording-window-only into feat/gpui-window-arrange-focus

662b388

# Conflicts: # apps/desktop-gpui/src/picker_probe.rs

vercel Bot deployed to Preview – cap-status October 27, 2026 04:11

View deployment

vercel Bot deployed to Preview – cap-web October 27, 2026 04:12

View deployment

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

Comment thread apps/desktop-gpui/src/app_windows.rs Outdated

Comment thread apps/desktop-gpui/src/picker_probe.rs

fix(desktop-gpui): run window moves and restores in order, and pick t…

6e2ab57

…he smoke's test window outright

vercel Bot deployed to Preview – cap-status October 27, 2026 06:21

View deployment

Merge feat/recording-window-only into feat/gpui-window-arrange-focus

6e3d8de

vercel Bot deployed to Preview – cap-status October 27, 2026 06:21

View deployment

vercel Bot deployed to Preview – cap-web October 27, 2026 06:22

View deployment

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

Comment thread apps/desktop-gpui/src/recording.rs

Comment thread apps/desktop-gpui/src/app_windows.rs Outdated

fix(desktop-gpui): say when Instant with a camera keeps the screen re…

0fbf152

…gion, and spawn the restore

vercel Bot deployed to Preview – cap-status October 27, 2026 20:34

View deployment

capy-ai Bot reviewed Oct 27, 2026

View reviewed changes

vercel Bot deployed to Preview – cap-web October 27, 2026 20:36

View deployment

Merge feat/recording-window-only into feat/gpui-window-arrange-focus

f220b1a

vercel Bot deployed to Preview – cap-status October 27, 2026 21:32

View deployment

capy-ai Bot reviewed Oct 27, 2026

View reviewed changes

vercel Bot deployed to Preview – cap-web October 27, 2026 21:33

View deployment

Merge feat/recording-window-only into feat/gpui-window-arrange-focus

06ab8c4

vercel Bot deployed to Preview – cap-status October 27, 2026 21:46

View deployment

vercel Bot deployed to Preview – cap-web October 27, 2026 21:47

View deployment

capy-ai Bot reviewed Oct 27, 2026

View reviewed changes

fix(desktop-gpui): wait for pending window moves before recording and…

d6c80f6

… put moved windows back on every non-recording exit

vercel Bot deployed to Preview – cap-status October 27, 2026 22:21

View deployment

vercel Bot had a problem deploying to Preview – cap-web October 27, 2026 22:24 Failure

richiemcilroy changed the base branch from feat/recording-window-only to main October 27, 2026 22:45

capy-ai Bot reviewed Oct 27, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

fix(desktop-gpui): tie a waiting Start to its picker, give up on wind…

a8bcd6c

…ows still moving, keep moved windows until recording commits

vercel Bot deployed to Preview – cap-status October 28, 2026 01:37

View deployment

vercel Bot had a problem deploying to Preview – cap-web October 28, 2026 01:39 Failure

capy-ai Bot reviewed Oct 28, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 28, 2026

View reviewed changes

fix(desktop-gpui): close the picker and show the main window when Sta…

be4fe9d

…rt gives up on a moving window

vercel Bot deployed to Preview – cap-status October 28, 2026 02:18

View deployment

superagent-security Bot reviewed Oct 28, 2026

View reviewed changes

vercel Bot deployed to Preview – cap-web October 28, 2026 02:20

View deployment

capy-ai Bot reviewed Oct 28, 2026

View reviewed changes

richiemcilroy merged commit e1df511 into main Oct 28, 2026
61 checks passed

Conversation

richiemcilroy commented Oct 27, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Change

Test

Confidence Score: 5/5

Findings

Summary

Uh oh!

vercel Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richiemcilroy commented Oct 27, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

richiemcilroy commented Oct 27, 2026

Uh oh!

Uh oh!

Uh oh!

richiemcilroy commented Oct 27, 2026

Uh oh!

Uh oh!

Uh oh!

richiemcilroy commented Oct 27, 2026

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot Oct 27, 2026

Choose a reason for hiding this comment

Deferred overlay Start can fire against a re-armed picker

Uh oh!

richiemcilroy commented Oct 27, 2026

Uh oh!

greptile-apps Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot Oct 28, 2026

Choose a reason for hiding this comment

Deferred Start records the click-time target after the pick changes

Uh oh!

richiemcilroy commented Oct 28, 2026

Uh oh!

greptile-apps Bot Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

superagent-security Bot left a comment

Choose a reason for hiding this comment

Uh oh!

superagent-security Bot Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

richiemcilroy Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

superagent-security Bot Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot left a comment

richiemcilroy commented Oct 27, 2026 •

edited by greptile-apps Bot

Loading

vercel Bot commented Oct 27, 2026 •

edited

Loading