Repository navigation
fix(extension): restore page styles after removing blur - #3445
Open
vedanth-jadhav wants to merge 2 commits into
Open
vedanth-jadhav wants to merge 2 commits into
vedanth-jadhav wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Author
|
@greptile review Please review the current head, including the extension's direct jsdom dev dependency and regenerated lockfile. |
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking an element to unblur it currently removes its original inline
user-selectsetting and drops the original filter's!importantpriority. The page can therefore behave or render differently after the blur is removed.Save and restore both inline values and their priorities. Keep the saved state on the element while the tool is closed, and remove the extension's metadata after unblurring. Elements that originally had no inline declarations return to that state.
Validation: all 45 extension tests pass, including six new mounted DOM cases. Four new cases fail before the fix. Covers important/ordinary styles, two complete blur cycles, closing/reopening the tool, originally absent styles, unrelated declarations, and ignoring extension controls. Strict source/test TypeScript with
noUncheckedIndexedAccess, scoped Biome and diff checks pass.Reproduce:
cd apps/chrome-extension && bun run test.The new tests use real DOM style declarations in jsdom. Browser installation, physical screen recording and a full extension build were not run. No runtime dependencies or recording/message contracts change. The extension declares jsdom ^26.1.0 as a development dependency. Bun 1.4.4 regenerated the lockfile and normalized existing package aliases; the set of resolved package versions has no additions or removals. Frozen lockfile validation also passes.
The current head appears safe to merge.Summary
Restores original inline
filteranduser-selectvalues and priorities after removing blur.No new actionable issues found. Tests and browser checks were not rerun during this review.
Reviews (2) · Last reviewed commit: "test(extension): declare the blur test D..." · Reviewed by Greptile