Skip to content

feat(desktop-gpui): enable the language picker in release builds - #3434

Closed
richiemcilroy wants to merge 4 commits into
ci/i18n-integration-062from
feat/gpui-language-picker-release
Closed

richiemcilroy wants to merge 4 commits into
ci/i18n-integration-062from
feat/gpui-language-picker-release

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Turns the language picker on for release builds, now that the settings, dialogs, editor panels and editor shell are translated (#3424, #3423, #3422, #3428).

Stacked on the i18n integration branch so the diff here is only these three commits. It gets retargeted to main once those four PRs land.

Changes

Picker in release builds (i18n/mod.rs, settings_window.rs)

  • Removes CAP_GPUI_LANGUAGE_PICKER and picker_enabled(). The Language section always shows on the General page.
  • The System preference now follows the system language in release builds too. Before, a release build stayed English on a non-English system because the picker was hidden.
  • uiLanguage and CAP_GPUI_LOCALE behave as before.

macOS language declaration and permission prompts (Info.plist, tauri.conf.json, macos/*.lproj)

  • Adds CFBundleDevelopmentRegion and CFBundleLocalizations for the seven shipped languages, so macOS treats Cap as localized.
  • Bundles InfoPlist.strings for each language, so the camera, microphone and screen recording permission prompts use the system language. zh-CN maps to zh-Hans.lproj.

Update, quit and Open Recording dialogs (updates.rs, menus.rs, installer.rs)

  • Moves the last English-only native dialogs into the catalogs: the update prompts (available, ready to restart, busy, failures, no update), the quit warnings while a recording or upload is in progress, and the Open Recording file prompt.
  • The update flow itself is unchanged. It still asks before downloading and before restarting.

Update menu while downloading (updates.rs, menus.rs, settings_window.rs)

  • A real download starts as Downloading { fraction: None } and stays that way when the server sends no size. The menu treated that as "Download update…" (enabled), and clicking it only said Cap was already getting the update ready.
  • Real downloads now always show the disabled "Downloading update…" row.
  • The debug update simulation's "available, not downloading yet" state gets its own Available variant. A real check never uses it, because it asks in a dialog before downloading.

Tests

  • dialogs_surface_tests pins every new English key to the literal it replaced, including formatted messages with their arguments (update_and_quit_messages_format_like_the_code_they_replaced).
  • tests.rs drops the picker-gating tests and pins menu.file.open_prompt.
  • The menu tests cover Available (enabled "Download update…") and an unsized download (disabled "Downloading update…").
  • The full cap-desktop-gpui test suite passes on macOS: 1496 passed, 0 failed.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable defects were found.

Summary

Enables the language picker in release builds and lets the default language follow the user's system preferences.

  • Release builds show the language picker and follow the system language by default.
  • macOS permission prompts use localized text for Cap’s seven shipped languages.
  • The Open Recording file prompt uses the selected language.
  • Update and quit dialogs use the selected language across the desktop app.
  • The update menu keeps every active download disabled, even when its size is unknown.
  • Update scheduler expressions are reformatted without changing behavior.

No actionable new issues were found. The full PR diff was reviewed because the previous-review ancestry and shared-base checks did not pass. No previous review threads were supplied. Builds, tests, and native UI checks were not run.

Reviews (2) · Last reviewed commit: "fix(desktop-gpui): keep a running update..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cap-status Ready Ready Preview Oct 26, 2026 10:25pm UTC

@richiemcilroy

Copy link
Copy Markdown
Member Author

@greptileai review

@richiemcilroy

Copy link
Copy Markdown
Member Author

@greptileai review

@richiemcilroy

Copy link
Copy Markdown
Member Author

Merged as part of #3516, together with current main and a full audit of every GPUI surface and translation.

This branch was successfully deployed

2 active deployments
Preview – cap-web — b6f26ae8 Deployed Oct 26, 2026 by vercel[bot]
Preview – cap-status — b6f26ae8 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant