Repository navigation
fix(desktop-gpui): reveal and open paths through GPUI (rebased #2965) - #3235
Merged
Merged
Conversation
On Windows, "open folder" / "reveal" actions opened the Documents folder instead of the recording bundle. `explorer /select,<path>` was passed as a single argument, so Rust quoted it (bundle names contain spaces) and Explorer ignored the switch. The editor's bundle path additionally comes from `std::fs::canonicalize`, whose `\?\` verbatim form the shell rejects with E_INVALIDARG. Replace the hand-rolled per-OS `open` / `explorer` / `cmd start` / `xdg-open` spawns with GPUI's `reveal_path` and `open_with_system`, behind `library::reveal_path` / `library::open_with_system` helpers that pass the path through `dunce::simplified` first. The tray's macOS-only `open` spawn goes through the same helpers.
Member
Author
|
@greptileai review |
richiemcilroy
marked this pull request as ready for review
October 25, 2026 18:27
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2965 by @Ectropy, rebased onto main. The commit and its authorship are unchanged.
Opening and revealing recordings now go through GPUI's
reveal_pathandopen_with_systeminstead of hand-spawnedopen,explorer /select,,cmd /C startandxdg-openprocesses:explorer /select,<path>was passed as a single argument, so Rust quoted it (bundle names contain spaces) and Explorer ignored the switch and opened Documents.std::fs::canonicalize's\\?\paths are now simplified withduncefirst.LD_LIBRARY_PATHreaching the file managerxdg-openstarted; fix(linux): AppImage screen capture on NixOS, niri DMA-BUF screencasts, paste test #3234 removes that at the launcher.Every call site that opened or revealed a path moved: the main window library, settings recordings and screenshots, the diagnostics report, the editor bundle button, the screenshot editor, "Open File" after an export, the deep link and the tray.
The PR appears safe to merge; no blocking issues were found.Summary
Routes desktop file-opening and reveal actions through GPUI.
No actionable issues were found. Native behavior was not tested; the pinned GPUI source was unavailable in this checkout.
Reviews (2) · Last reviewed commit: "fix(desktop-gpui): reveal and open paths..." · Reviewed by Greptile