Repository navigation
fix(desktop-gpui): restore focus after closing Settings dropdowns - #3110
Merged
richiemcilroy merged 2 commits intoOct 24, 2026
Merged
Conversation
Contributor
|
@vedantggwp is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a keyboard-opened Settings dropdown leaves focus on the window root, so the next Tab jumps back to the sidebar. This restores focus to the originating control after Escape or selection, provided keyboard mode remains active and focus hasn’t moved elsewhere.
Follow-up to testing feedback on #2775.
Tested on macOS using an isolated app/profile:
c9a917a53.cargo check, and 29 existing Settings/menu/navigation tests passed.Changed-file formatting passes. Workspace formatting and Clippy report existing failures, confirmed against unchanged main. Focus restoration was tested in the running app; the existing unit tests don’t directly cover it.
Mouse dropdown interaction remains unverified because the automation tool failed to resolve coordinate clicks. No screen-reader or other-platform testing claimed.


Confidence Score: 5/5
The PR appears safe to merge; no actionable defects were found.Summary
Restores focus after a keyboard-opened Settings dropdown closes.
Static review found no actionable issues. Native UI behavior was not independently tested on this Linux host.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): restore focus after c..." · Reviewed by Greptile