[shockalotti]

Follow-up to #156. Adds the clone-module step and documents the behaviour.

First, a correction to what I told you

I said we shipping no clone-module action was a real functional gap. It is not. NethServer/ns8-kickstart, the official module template, declares only configure-module and get-configuration, and the core ships a partial default clone-module implementation that rsyncs the volumes and state/. So cloning already worked. My framing overstated it, and I have fixed the framing rather than quietly doing the work anyway.

What the default does not handle

Two things in state/ belong to one hostname:

• config.json — the hostname and TLS flags
• calnode.env — BASE_URL, derived from that hostname

The Traefik route is registered by configure-module and belongs to one instance, so it is not copied; routes are keyed by MODULE_ID. A clone therefore arrives holding the source's hostname with no route of its own, and configuring it with that hostname is then refused, because the source still answers for it and configure-module refuses to steal a hostname another route already serves.

So the clone is not a clean failure. It is a quietly broken instance that looks like a configuration bug. That is worse than not supporting clone at all, which is worth saying plainly.

The step

imageroot/actions/clone-module/20unclaimhostname releases the hostname: config.json is removed and BASE_URL dropped. get-configuration then reports configured:false and the Settings page asks for a hostname, so the clone lands in exactly the state a freshly added instance is in.

It runs at 20, after the core moves data in 10recvstate and before it starts the service in 90finalize.

What it must not release is CALNODE_ENCRYPTION_KEY. It travels with the copied database and is the only thing that can unwrap the database key vault. Dropping it hands back an unreadable copy of every booking, which is strictly worse than the bug being fixed. The rewrite therefore fails loudly rather than writing an env file without the key.

Tests

8 cases in test_clone_module.py, wired into the same validate job as the existing suite, so a regression fails on every push:

• the key survives while BASE_URL does not
• config.json is removed
• a missing config.json or calnode.env is not an error
• the refusal path when the key would be lost
• file mode stays 0600
• comments and blank lines survive the rewrite
• the step is idempotent, because action steps can be retried

17 tests in the packaging suite in total, all passing.

Honest caveat

This is verified by unit tests and by reading the core implementation. It has not been cloned on a real cluster. That needs a live NS8 node and the robot suite does not cover clone yet.

So I would not tell anyone a clone is supported yet. Worth adding a clone case to the robot suite before this goes out, and that is the one thing here I would want done rather than assumed.

Docs

README gains a Clone and move section, stating that the encryption key is kept and the hostname is not, and why. Better documented than discovered.

[pullfrog]

The model provider returned an error, so this run stopped.

The error is below. If it names your key, plan or balance, fix that with the provider or pick another model before re-triggering.

Model settings → · Ask in Discord →

provider error: This API key has expired. Create a new API key in OpenCode Console and replace it in your client or secret store. Signing in again will not renew this key.

  ^{｜ Rerun failed job ➔ ｜ View workflow run ｜ via Pullfrog ｜ Using space-bunny-free (free) ｜ 𝕏}

[pullfrog]

The model provider returned an error, so this run stopped.

The error is below. If it names your key, plan or balance, fix that with the provider or pick another model before re-triggering.

Model settings → · Ask in Discord →

provider error: This API key has expired. Create a new API key in OpenCode Console and replace it in your client or secret store. Signing in again will not renew this key.

  ^{｜ Rerun failed job ➔ ｜ View workflow run ｜ via Pullfrog ｜ Using space-bunny-free (free) ｜ 𝕏}

[shockalotti]

Same careful look. This one is good, and the important parts are honest about the risk.

What I verified rather than took on trust:

• The encryption key really is preserved. Dropping CALNODE_ENCRYPTION_KEY would leave a clone with a database it cannot decrypt, which is worse than the bug being fixed. The script keeps it and drops only BASE_URL.
• Removing config.json is safe. You claim get-configuration reports configured:false when it is absent. I checked: it catches FileNotFoundError and returns the defaults with configured: False. The claim holds.
• The tests actually run in CI. The workflow change looks like it only adds a py_compile line, but the existing python3 -m unittest discover -s . -p "test_*.py" step picks up test_clone_module.py. 8 tests, all pass locally.
• The PR build pushes nothing. The ns8-module publish step is gated on github.event_name != "pull_request", so a fork PR cannot push tags.

One nit, not a blocker. In drop_hostname_from_env, the "refuse to write an env file without the key" check runs after the file has already been rewritten. It cannot actually lose the key, because the function only removes BASE_URL, so it guards against a pre-existing condition rather than a real risk. Moving the check above the write would make it match its own comment.

Sequencing. #156 and this PR both add a section at README line 129, so they conflict. #156 merges first, then rebase this onto main.

The reasoning about routes being keyed by MODULE_ID, and about a clone arriving deliberately unconfigured rather than quietly broken, is correct and worth keeping.

[pullfrog]

OpenCode Go returned an error, so this run stopped. If it names your key, plan or balance, fix that with the provider or pick another model.

This API key has expired. Create a new API key in OpenCode Console and replace it in your client or secret store. Signing in again will not renew this key.

Pick another model →

  ^{｜ Rerun failed job ➔ ｜ View workflow run ｜ via Pullfrog ｜ Using deepseek-v4.1-flash}

[pullfrog]

OpenCode Go returned an error, so this run stopped. If it names your key, plan or balance, fix that with the provider or pick another model.

This API key has expired. Create a new API key in OpenCode Console and replace it in your client or secret store. Signing in again will not renew this key.

Pick another model →

  ^{｜ Rerun failed job ➔ ｜ View workflow run ｜ via Pullfrog ｜ Using deepseek-v4.1-flash}