Repository navigation
security: normalize the navigation location before building breadcrumb URLs - #47
Merged
Merged
Conversation
somethingwithproof
force-pushed
the
fix/nav-location
branch
2 times, most recently
from
October 18, 2026 05:23
0777488 to
fdcd44f
Compare
…b URLs Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/nav-location
branch
from
October 18, 2026 06:11
fdcd44f to
f33731a
Compare
|
TheWitness
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quicktree_draw_navigation_text() put the raw location request value into the breadcrumb URL and compared it for the console mapping. It now goes through quicktree_normalize_location(), so only console or tab can reach the URL.
Found while reviewing #42 and #43; the line predates both and is independent of them.
Tests: three Pest cases (console, tab, and a value with quotes, angle brackets and an ampersand). Checked the function with those inputs in php:8.3-cli; Pest runs in CI.