Skip to content

incorrect type on get_user_by_email() #153

Open

Description

@cardoe

The current signature is def get_user_by_email(db: Session, email: str) -> schemas.UserBase: but I believe this to be incorrect. It should be def get_user_by_email(db: Session, email: str) -> schemas.User:. The reason is that this function returns the DB row which includes the id as part of the model.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions