How to combine quickcheck 1+ with fake? #320

Activity

1. joshuamegnauth54 commented on Dec 23, 2023

   

   joshuamegnauth54

   on Dec 23, 2023

   Last edited by joshuamegnauth54

   More actions

   I've encountered the same issue. I solved it in a hacky way by reimplementing SafeEmail.

   #[cfg(test)]
   mod tests {
       use fake::locales::{self, Data};
       use quickcheck::{Arbitrary, Gen};
   
       #[derive(Debug, Clone)]
       struct ValidEmailFixture(pub String);
   
       impl Arbitrary for ValidEmailFixture {
           fn arbitrary(g: &mut Gen) -> Self {
               let username = g
                   .choose(locales::EN::NAME_FIRST_NAME)
                   .unwrap()
                   .to_lowercase();
               let domain = g.choose(&["com", "net", "org"]).unwrap();
               let email = format!("{username}@example.{domain}");
               Self(email)
           }
       }
   
       #[quickcheck_macros::quickcheck]
       fn valid_emails_are_parsed_successfully(email: ValidEmailFixture) -> bool {
           SubscriberEmail::parse(email.0).is_ok()
       }
   }

   Not ideal but also not too bad.

   Zero to Production's author, Luca Palmieri, posted an excerpt that covers OP's code above if anyone wants to follow along.

   👍React with 👍5Reacted by JungChul Shin, dunxen, Tiago Amorim, Caleb Reyes and Vladislav Gardner
2. npuichigo commented on Jan 25, 2024

   

   npuichigo

   on Jan 25, 2024

   More actions

   Same issue here @BurntSushi. How to use quickcheck together with other tools like fake which needs an RNG
3. choco-green commented on Apr 30, 2024

   

   choco-green

   on Apr 30, 2024

   More actions

   I've encountered the same issue. I solved it in a hacky way by reimplementing SafeEmail.

   #[cfg(test)]
   mod tests {
       use fake::locales::{self, Data};
       use quickcheck::{Arbitrary, Gen};
   
       #[derive(Debug, Clone)]
       struct ValidEmailFixture(pub String);
   
       impl Arbitrary for ValidEmailFixture {
           fn arbitrary(g: &mut Gen) -> Self {
               let username = g
                   .choose(locales::EN::NAME_FIRST_NAME)
                   .unwrap()
                   .to_lowercase();
               let domain = g.choose(&["com", "net", "org"]).unwrap();
               let email = format!("{username}@example.{domain}");
               Self(email)
           }
       }
   
       #[quickcheck_macros::quickcheck]
       fn valid_emails_are_parsed_successfully(email: ValidEmailFixture) -> bool {
           SubscriberEmail::parse(email.0).is_ok()
       }
   }

   Not ideal but also not too bad.

   Zero to Production's author, Luca Palmieri, posted an excerpt that covers OP's code above if anyone wants to follow along.

   An extension for more context if you came here from the same book - This is exactly how fake is implmenting the safeEmail function.

   impl<L: Data + Copy> Dummy<SafeEmail<L>> for String {
       fn dummy_with_rng<R: Rng + ?Sized>(c: &SafeEmail<L>, rng: &mut R) -> Self {
           let username: String = FirstName(c.0).fake_with_rng::<&str, _>(rng).to_lowercase();
           let domain = ["com", "net", "org"].choose(rng).unwrap();
           format!("{}@example.{}", username, domain)
       }
   }

   For more information, there is #265 to read for why rng is no longer a dependency.

   Enough Digging, Enjoy coding :3
4. dead-claudia

   added a commit that references this issue on Jul 6, 2024

   Replace QuickCheck with an own propcheck utility

   ...

   b3c20e1