Skip to content

Remove Uri.EscapeUriString #103

New issue
New issue
Closed
#120
Closed
Remove Uri.EscapeUriString#103
#120

Description

@flytzen
flytzen
opened on Apr 13, 2022

GoogleAuthenticator/Google.Authenticator/TwoFactorAuthenticator.cs

Line 63 in c464ba3

accountTitleNoSpaces = RemoveWhitespace(Uri.EscapeUriString(accountTitleNoSpaces));

EscapeUriString is obsolete from .Net 6.0. However, it's recommended replacement EscapeDataString changes the output. Specifically, it changes "a@b.com" becomes "a%40b.com".

For now, we are ignoring the warning, but this should be understood more deeply and fixed at some point.

Activity

  1. ahwm commented on Apr 13, 2022

    @ahwm
    ahwm
    on Apr 13, 2022
    Collaborator

    @flytzen I actually just saw something about that in a PR - Shane32/QRCoder#391

    Based on tests there, looks like it should be a%40b.com

  2. flytzen commented on Apr 13, 2022

    @flytzen
    flytzen
    on Apr 13, 2022
    CollaboratorAuthor

    @flytzen I actually just saw something about that in a PR - codebude/QRCoder#391

    Based on tests there, looks like it should be a%40b.com

    Interesting. Problem is, that would probably be a breaking change so we would need to handle it carefully, at least.

  3. ahwm
    closed this as completedin #120on May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions