Repository navigation
Publish to PyPI through trusted publishing - #3
Merged
Merged
Conversation
The release job built and attached the artifacts but skipped the upload, since the repo has no PyPI token. Split publishing into its own job with id-token: write in a "pypi" environment, so PyPI can trust the workflow directly and nothing long-lived is stored in the repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow skipped the PyPI upload because there's no token secret, so 1.0.0 and 1.0.1 went up by hand with twine.This moves the upload into a separatepublishjob that runs in apypienvironment withid-token: writeand uses pypa/gh-action-pypi-publish. The build job hands overdist/as an artifact, so tests and the build never run with the OIDC permission.It needs a trusted publisher on the PyPI side (owner Booyaka101, repo diskstack, workflowrelease.yml, environmentpypi). Until that exists the publish job fails on the next tag. The GitHub release and its artifacts still get made first.`🤖 Generated with Claude Code