How determine if need expand the text? #2

Activity

1. Cliffus commented on May 24, 2016

   

   Cliffus

   on May 24, 2016

   Contributor

   More actions

   Hi

   the ExpandableTextView currently doesn't have support for the described behaviour. I'll look into it and get back to you soon.

   Thanks for using ExpandableTextView and reporting this feature request!
2. Cliffus

   added

   enhancement

   on May 28, 2016
3. Cliffus

   added this to the 1.1.0 milestone on May 28, 2016
4. Cliffus

   self-assigned this

   on May 28, 2016
5. webserveis commented on Jun 5, 2016

   

   webserveis

   on Jun 5, 2016

   Author

   More actions

   Hi,

   To determine if you have to expand or not , I use that code , and I was a copy paste of a set of tips, if not the best way, I am a newbie in Android

           final View myView = findViewById(R.id.expandableTextView);
           if (myView != null) {
               myView.getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {
                   @SuppressWarnings("deprecation")
                   @Override
                   public void onGlobalLayout() {
   
                       Log.d(TAG, "getLineCount " + (expandableTextView != null ? expandableTextView.getLineCount() : 0));
                       Log.d(TAG, "getMaxLines " + (expandableTextView != null ? expandableTextView.getMaxLines() : 0));
   
                       if (expandableTextView != null) {
   
                           int start = expandableTextView.getLayout().getLineStart(0);
                           int end = expandableTextView.getLayout().getLineEnd(expandableTextView.getLineCount() - 1);
   
                           String displayed = expandableTextView.getText().toString().substring(start, end);
   
                           if (displayed.length() == expandableTextView.getText().length()) {
                               Log.d(TAG, "NO NEED TO EXPAND ");
                           } else {
                               Log.d(TAG, "NEED TO EXPAND ");
                           }
   
                       }
   
                       if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
                           myView.getViewTreeObserver().removeOnGlobalLayoutListener(this);
                       } else {
                           myView.getViewTreeObserver().removeGlobalOnLayoutListener(this);
                       }
                   }
               });
           }
   

   👍React with 👍3Reacted by Hiroyuki Onishi, Alexander Chiou and luisg122
6. Cliffus commented on Jun 5, 2016

   

   Cliffus

   on Jun 5, 2016

   Contributor

   More actions

   thanks for the tip! I'll take a look at it and try to integrate it in ExpandableTextView

   👍React with 👍3Reacted by Hiroyuki Onishi, Alexander Chiou and Sergei
7. Cliffus commented on Aug 2, 2016

   

   Cliffus

   on Aug 2, 2016

   Contributor

   More actions

   just letting you know that I'm finally started working on this feature. I'll keep you posted!

   👍React with 👍5Reacted by Webserveis, Michael Chang, Iago Santos, sagar patel and luisg122
8. RedshirtMB commented on Sep 27, 2016

   

   RedshirtMB

   on Sep 27, 2016

   More actions

   I liked the suggestion by @webserveis . I wrapped the widget in a widget of my own, cleverly called ExpandableTextView :) I set the global listener right before setting the text.

   public class ExpandableTextView extends LinearLayout {
   
       private at.blogc.android.views.ExpandableTextView textView;
       private Button button;
       private LinearLayout expander;
   
       public ExpandableTextView(Context context) {
           super(context);
           initialize(context);
       }
   
       public ExpandableTextView(Context context, AttributeSet attrs) {
           super(context, attrs);
           initialize(context);
       }
   
       public ExpandableTextView(Context context, AttributeSet attrs, int defStyleAttr) {
           super(context, attrs, defStyleAttr);
           initialize(context);
       }
   
       @TargetApi(21)
       public ExpandableTextView(Context context, AttributeSet attrs, int defStyleAttr, int defStyleRes) {
           super(context, attrs, defStyleAttr, defStyleRes);
           initialize(context);
       }
   
       private void initialize(Context context) {
           LayoutInflater.from(context).inflate(R.layout.widget_expandable_textview, (ViewGroup) getRootView(), true);
   
           textView = (at.blogc.android.views.ExpandableTextView) findViewById(R.id.expanderText);
           textView.setAnimationDuration(1000L);
           textView.setInterpolator(new OvershootInterpolator());
           textView.setOnExpandListener(new at.blogc.android.views.ExpandableTextView.OnExpandListener() {
               @Override
               public void onExpand(at.blogc.android.views.ExpandableTextView view) {
                   button.setText(R.string.less);
               }
   
               @Override
               public void onCollapse(at.blogc.android.views.ExpandableTextView view) {
                   button.setText(R.string.more);
               }
           });
           button = (Button) findViewById(R.id.expanderMoreButton);
           expander = (LinearLayout) findViewById(R.id.expander);
           button.setOnClickListener(new OnClickListener() {
               @Override
               public void onClick(View view) {
                   textView.toggle();
               }
           });
       }
   
       public void setText(CharSequence text) {
           addGlobalListener();
           textView.setText(text);
       }
   
       private void addGlobalListener() {
           if (textView == null) return;
           getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {
               @SuppressWarnings("deprecation")
               @Override
               public void onGlobalLayout() {
                   int start = textView.getLayout().getLineStart(0);
                   int end = textView.getLayout().getLineEnd(textView.getLineCount() - 1);
   
                   String displayed = textView.getText().toString().substring(start, end);
   
                   if (displayed.length() == textView.getText().length()) {
                       expander.setVisibility(GONE);
                   } else {
                       expander.setVisibility(VISIBLE);
                   }
   
                   if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
                       getViewTreeObserver().removeOnGlobalLayoutListener(this);
                   } else {
                       getViewTreeObserver().removeGlobalOnLayoutListener(this);
                   }
               }
           });
       }
   }
   

   👍React with 👍5Reacted by Webserveis, Anh Duong, Julia-Ts, Luka Dulčić and luisg122
9. Julia-Ts commented on Mar 29, 2017

   

   Julia-Ts

   on Mar 29, 2017

   Last edited by Julia-Ts

   More actions

   Thanks for the solution provided above, but it works only if text contains "\n". It is better to use ellipsize attribute on ExpandableTextView and check for it in OnGlobalLayoutListener like this:

    getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {
   
        @Override
               public void onGlobalLayout() {
                   Layout layout = textView.getLayout();
                   if (layout != null) {
                       int lines = layout.getLineCount();
                       if (lines > 0) {
                           int ellipsisCount = layout.getEllipsisCount(lines - 1);
                           if (ellipsisCount > 0) {
                               expander.setVisibility(VISIBLE);
                           } else {
                               expander.setVisibility(GONE);
                           }
                       }
                   }
   
                   if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
                       getViewTreeObserver().removeOnGlobalLayoutListener(this);
                   } else {
                       getViewTreeObserver().removeGlobalOnLayoutListener(this);
                   }
               }
           });
   

   👍React with 👍6Reacted by Luka Dulčić, Denis Marinx, GreenVegetables, Tuan Giao , Maksim Lin and luisg122
10. vkdinventor commented on Jun 24, 2017

    

    vkdinventor

    on Jun 24, 2017

    More actions

    If someone is still looking for this feature Please see this answer

    👍React with 👍1Reacted by luisg122
11. vkdinventor

    added a commit that references this issue on Jun 24, 2017

    fix for issue Blogcat#2 when text takes up less line than threshold, …

    ...

    025a5fe
12. manish-poddar commented on May 15, 2018

    

    manish-poddar

    on May 15, 2018

    More actions

    Hi @Cliffus
    Any solution to this issue? Have you incorporated some method in your library ?
13. vkdinventor commented on Jun 20, 2018

    

    vkdinventor

    on Jun 20, 2018

    More actions

    @manish-poddar Use this https://github.com/vkdinventor/Android-ExpandableTextView
14. manish-poddar commented on Jun 21, 2018

    

    manish-poddar

    on Jun 21, 2018

    More actions

    @vkdinventor isn't this the same library you forked? I couldn't see any method which determines the need to expand. If there is some, please give me the snippet.
15. vkdinventor commented on Jun 27, 2018

    

    vkdinventor

    on Jun 27, 2018

    Last edited by vkdinventor

    More actions

    @manish-poddar In my version of this library, you can set maximum line count. So if text takes less than max line count, expand button would be disabled.
    see commit
16. J6ey commented on Dec 15, 2018

    

    J6ey

    on Dec 15, 2018

    Last edited by J6ey

    More actions

    An even easier way is to just check if the ExpandableTextView is ellipsized.

    Layout layout = expTextView.getLayout();
    if(layout != null) {
        int lines = layout.getLineCount();
        if(lines > 0) {
            int ellipsisCount = layout.getEllipsisCount(lines-1);
            if ( ellipsisCount > 0) {
                Log.d(TAG, "Text is ellipsized; show expand button");
            } 
        } 
    }
    

    👍React with 👍1Reacted by Webserveis
17. sagarpatel288 commented on Feb 18, 2019

    

    sagarpatel288

    on Feb 18, 2019

    More actions

    If anyone has problem getting this done properly in recyclerView, simply set value first in onBind and then in handler, check line count and execute your logic based on line count...
18. igor-alyoshin

    added a commit that references this issue on Jun 30, 2020

    Notify on expanded Blogcat#2

    908185d