Repository navigation
Conversation
Contributor
Contributor
|
|
Marzooqa
force-pushed
the
marzooqanaeemakather/wci-2009-fix-sol-token-transfer-failures-in-the-mpcv2-flow
branch
from
October 21, 2026 13:47
c966f80 to
3fce1af
Compare
Marzooqa
force-pushed
the
marzooqanaeemakather/wci-2009-fix-sol-token-transfer-failures-in-the-mpcv2-flow
branch
from
October 23, 2026 10:20
ff246bc to
13e7807
Compare
Token transfers sent with explicit txParams recipients that carry no tokenName failed local verification with "Tx outputs does not match with expected txParams recipients". On a token wallet getChain() is the token itself, so a recipient without tokenName is still a token transfer; default it so the ATA derivation check can match. Ticket: WCI-2009 Co-Authored-By: Claude <noreply@anthropic.com>
Marzooqa
force-pushed
the
marzooqanaeemakather/wci-2009-fix-sol-token-transfer-failures-in-the-mpcv2-flow
branch
from
October 23, 2026 10:24
13e7807 to
e25cd94
Compare
Marzooqa
marked this pull request as ready for review
October 23, 2026 12:14
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SOL token transfers sent with explicit
txParamsrecipients that carry notokenNamefail local verification withTx outputs does not match with expected txParams recipients(WCI-2009).Root cause.
Sol.verifyTransactioncompares each recipient to the parsed tx output. For a token transfer the output address is the recipient's associated token account (ATA), so the check only passes when it can derive that ATA from the recipient's owner address, which requiresrecipient.tokenName. A recipient of{ address, amount }on a token wallet (e.g.tsol:usdcv2) has notokenName, so the ATA branch is skipped and the check returns false.Fix. On a token wallet
getChain()is the token itself, so a recipient withouttokenNameis still a token transfer.Sol.verifyTransactionnow defaults a missingtokenNametothis.getChain()when the coin is a token. Native SOL wallets are unaffected. An explicitly suppliedtokenNameis never overridden, so a wrong token still fails verification.This supersedes the earlier
recipientUtilsresolver approach on this branch, which only affected the EdDSA MPCv2 intent-rebuild path and did not cover this case.Issue Number
WCI-2009
Type of change
How Has This Been Tested?
POST /api/v2/tsol:usdcv2/wallet/<id>/sendcoinswith{address, amount}failed with the error above before the change and succeeds after it.sdk-coin-sol/test/unit/sol.tsusing atsol:usdctoken coin: a recipient withouttokenNameverifies, and a wrong amount is still rejected. It fails with the fix reverted.sdk-coin-solunit suite passes (876).eslintandprettierclean.Checklist