Repository navigation
Move server_name/service_name in RegisterRosAction/RegisterRosService #14
Description
I think that the server_name and service_name bloats the behavior-tree and additionally add "ros logic" into the behavior-tree.
It would be more elegant in my opinion to add the server_name/service_name when registering the node.
I tried to make the change myself, but the nodes are always failing.
Can somebody help me with?
Thanks
Activity
facontidavide commentedon May 20, 2022
I understand the fact that it add bloat, but I would rather keep two implementation (name as port or passed to the constructor).
To understand why your modified version don't work, you need to share a runnable example with me.
panwauu commentedon May 20, 2022
Good point to keep both options!
I started PR #16 to show my version.