Repository navigation
fix(write): preserve exact JSON timestamps - #73
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON writes converted decimal and exponent timestamps through
float64, changing values such as1.700000000000000001e18to1700000000000000000. Parse them as exact decimal integers instead, preserving nanosecond precision and rejecting fractional or out-of-range epochs. Adds row/columnar regression tests, comparisons against rational arithmetic and a check of the uploaded MessagePack bytes.On macOS arm64 with Go 1.27.1,
go test -race -count=1 ./...passed on the second full run;go vet ./...,go build ./...,gofmt -l .andgit diff --checkalso passed. The first full run failed in unchangedTestFetchPreservesDownloadError/forbiddenwithcontext canceledinstead of HTTP 403; ten isolated reruns passed. The timestamp regressions failed before the fix. Linux CI and the GoReleaser snapshot have not been run locally.