Repository navigation
fix(config): remove dead license.enabled key - #1241
Merged
xe-nvdk merged 2 commits intoOct 13, 2026
Merged
Conversation
xe-nvdk
approved these changes
Oct 13, 2026
xe-nvdk
left a comment
Member
There was a problem hiding this comment.
Thanks @lecodev-26. I verified this locally since you couldn't build it. It removes exactly the three sites #1195 lists, and nothing else references the key in code, arc.toml, either chart or the docs. It merges cleanly with current main, and go vet ./... plus the config, license and source-guard tests pass on the result. A build with [license] enabled = true in arc.toml and ARC_LICENSE_ENABLED=true in the environment starts normally and runs as OSS, so a leftover key stays a no-op.
I pushed a release note to the branch (c699c7b), under Internal changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1195.
license.enabledwas read intoLicenseConfig.Enabledand given a default, but nothing consumes the field. License loading incmd/arc/main.gois driven only bylicense.file_pathandlicense.key, so the key does nothing today, and wiring it up later could silently disable Enterprise features for existing deployments.This removes the struct field, its read in
Load()and its default insetDefaults. No behaviour change: alicense.enabledentry in an existing config is ignored, as it already was.I checked the repo for other references (Go code, tests, TOML, docs, chart) and found none.
Validation:
gofmtis clean. I did not build or run tests locally (Termux cannot build the native dependencies), so please rely on the GitHub Actions run.