Skip to content

fix(config): remove dead license.enabled key - #1241

Merged
xe-nvdk merged 2 commits into
Basekick-Labs:mainfrom
lecodev-26:fix/1195-remove-dead-license-enabled
Oct 13, 2026
Merged

xe-nvdk merged 2 commits into
Basekick-Labs:mainfrom
lecodev-26:fix/1195-remove-dead-license-enabled

Conversation

@lecodev-26

Copy link
Copy Markdown
Contributor

Closes #1195.

license.enabled was read into LicenseConfig.Enabled and given a default, but nothing consumes the field. License loading in cmd/arc/main.go is driven only by license.file_path and license.key, so the key does nothing today, and wiring it up later could silently disable Enterprise features for existing deployments.

This removes the struct field, its read in Load() and its default in setDefaults. No behaviour change: a license.enabled entry in an existing config is ignored, as it already was.

I checked the repo for other references (Go code, tests, TOML, docs, chart) and found none.

Validation: gofmt is clean. I did not build or run tests locally (Termux cannot build the native dependencies), so please rely on the GitHub Actions run.

@xe-nvdk xe-nvdk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lecodev-26. I verified this locally since you couldn't build it. It removes exactly the three sites #1195 lists, and nothing else references the key in code, arc.toml, either chart or the docs. It merges cleanly with current main, and go vet ./... plus the config, license and source-guard tests pass on the result. A build with [license] enabled = true in arc.toml and ARC_LICENSE_ENABLED=true in the environment starts normally and runs as OSS, so a leftover key stays a no-op.

I pushed a release note to the branch (c699c7b), under Internal changes.

@xe-nvdk
xe-nvdk merged commit 3bb41d1 into Basekick-Labs:main Oct 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead license.enabled config key — 0 consumers, and wiring it up later would silently disable Enterprise

2 participants