Repository navigation
Address review: CopraRNA2, IntaRNAsTar, compressed genomes and vector reports - #3
Merged
Merged
Conversation
# Conflicts: # AGENTS.md
Member
|
thanks, please revise: some of the following tasks might already be implemented in the current code. double check and ignore if that's the case. drop CopraRNA1 legacy codewithin the reimplementation, we will remove the CopraRNA1 old version legacy code
update dependencies and their integration
"Phylogeny/compatible.treefile"if the new implementation still produces the file nw_display -S -w 500 -v 20 -s Phylogeny/compatible.treefile > Phylogeny/compatible.treefile.svgcheck for a python only solution to reduce the dependency list to python packages. if not possible, refer to the given tool images
input fasta filethe original code moves the input fasta file to a subfolder.
keep genome files compressed
full complementarity check
code documentation
ChangeLog fileadd a "ChangeLog.md" file that provides the needed documentation to compile the next release change information:
|
…ssed genome reuse
Fix formatting and punctuation in README.md regarding DAVID service requirements and report generation.
Updated email account for DAVID requests and clarified CSV import handling.
…ntext Fix genomic target accessibility boundaries
Prepare the Python-only CopraRNA 3.0.0 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes the Python follow-up for #1 after Martin Raden’s review, stacked on #2. The runtime now supports CopraRNA2 only and uses IntaRNA >=3 with the IntaRNAsTar personality. File or inline native parameter contents are forwarded to every prediction, including web exports.
Genomes are downloaded and parsed as gzip, shared through a locked database directory, and read directly without per-job copies. IntaRNA CSV intermediates stay compressed. Gap-free helices spanning at least 90% of either effective RNA length are removed before energy fitting, with an audit of removed IDs and coordinates. Prediction cache signatures cover native settings and input contents. The original input FASTA stays byte unchanged at its original path; cleanup also protects supplied native parameter files, their reproducibility snapshot and nested inputs.
The web export applies the same helix filter and selects a retained interaction, preventing discarded best hits from reappearing in diagrams. Scientific diagrams now have vector PDF/SVG exports, all extended-list pages are retained, and the phylogeny has a Python-rendered SVG. Reports handle unavailable comparative scores. The current dependency environment uses BLAST+ and reviewed Python releases; separate optional Perl/R oracle environments avoid conflicting historical XML libraries.
The earlier parsing, statistical, DomClust and plotting corrections remain documented in ChangeLog.md. Function documentation explains scientific conventions and file side effects, and AGENTS.md records the maintenance requirements. Original tracked sources remain byte unchanged. Historical whole-workflow equality is intentionally replaced by explicit contracts for the reviewed scientific defaults; retained helper/statistical oracles still match independently captured output.
Validation: 171 passed, 2 skipped with native workflows, file/inline equivalence, a real perfect-helix prediction, browser vector exports, R/Perl comparisons and all 17 bundled reference genomes (51 region comparisons). The skips cover the intentionally updated archive README oracle and an unavailable optional legacy NCBI module. A fresh production environment installs successfully; both optional interpreter specifications solve. Wheel/sdist builds pass, all 35 retained fixture cases pass from an installed wheel outside the checkout, and that wheel completes a native prediction with web exports. All four CI jobs pass on final commit
a3977c8(Python 3.11–3.13 and the full scientific environment), for both push and pull-request runs.Follow-up completeness audit (2026-10-22): rechecked the original issue and every review/comment endpoint. Closed input/output basename and symlink collisions, protected cleanup destinations, enforced IntaRNA >=3 at every standalone native entry point, and made native cache signatures use the detected release. Completed the remaining public API documentation and added a requirement-by-requirement implementation/test table to AGENTS.md. All listed requests are covered; original tracked source checksums remain unchanged.