Repository navigation
Run missing unit test projects in the ADO PR build - #3934
Merged
Merged
Conversation
The unit-test VSTest step only ran Microsoft.Identity.Web.Test.dll, skipping four projects the GitHub Action already covers: UI.Test, Sidecar.Tests (126 tests), OidcIdp and CustomSignedAssertion provider tests. All are built by the full solution build, so add them to the unit-test glob. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Iarek Kovtunenko (iarekk)
marked this pull request as ready for review
July 9, 2026 18:41
Neha Bhargava (neha-bhargava)
approved these changes
Jul 9, 2026
Gladwin Johnson VR (gladjohn)
approved these changes
Jul 9, 2026
Sidecar.Tests contains SidecarEndpointsE2ETests and SidecarIntegrationTests that need a live sidecar and are filtered out in the GitHub Action. They failed on the hosted ADO agent. Add the same VSTest filter so only the in-memory Sidecar tests run, matching GH parity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Neha Bhargava (neha-bhargava)
approved these changes
Jul 9, 2026
Gladwin Johnson VR (gladjohn)
approved these changes
Jul 9, 2026
Copilot AI
added a commit
that referenced
this pull request
Jul 9, 2026
…est template, original MI client ID; delete 5 added template files
This was referenced Jul 10, 2026
Closed
Closed
Merged
Iarek Kovtunenko (iarekk)
added a commit
that referenced
this pull request
Jul 10, 2026
Restores the 4-stage PR pipeline and extra unit-test coverage from #3933/#3934 (reverted in #3936), with two fixes so the managed-identity E2E test runs on every pool that consumes these tests: - TokenAcquirer MI test now reads the UAMI client id from IDWEB_MI_UAMI_CLIENTID, falling back to the Msal_Integration_tests identity (45344e7d) assigned to the Wilson pool used by the id4s-official pipeline. That pipeline needs no changes. - template-run-managed-identity-e2e-tests.yaml sets IDWEB_MI_UAMI_CLIENTID to the msiv2uami identity (6325cd32) assigned to the MSALMSIV2 pool, so the Id.Web PR pipeline and IdWeb OneBranch official MI job use it. Also re-adds the net462/net472 dotnet test steps that VSTest@2 cannot discover on hosted agents. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Iarek Kovtunenko (iarekk)
added a commit
that referenced
this pull request
Jul 10, 2026
Restores the 4-stage PR pipeline and extra unit-test coverage from #3933/#3934 (reverted in #3936), with two fixes so the managed-identity E2E test runs on every pool that consumes these tests: - TokenAcquirer MI test now reads the UAMI client id from IDWEB_MI_UAMI_CLIENTID, falling back to the Msal_Integration_tests identity (45344e7d) assigned to the Wilson pool used by the id4s-official pipeline. That pipeline needs no changes. - template-run-managed-identity-e2e-tests.yaml sets IDWEB_MI_UAMI_CLIENTID to the msiv2uami identity (6325cd32) assigned to the MSALMSIV2 pool, so the Id.Web PR pipeline and IdWeb OneBranch official MI job use it. Also re-adds the net472 dotnet test step that VSTest@2 cannot discover on hosted agents. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 30, 2026
Closed
This was referenced Oct 7, 2026
This was referenced Oct 14, 2026
This was referenced Oct 21, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADO PR build's unit-test step only globbed
Microsoft.Identity.Web.Test.dll, so four unit test projects that thedotnetcore.ymlGitHub Action already runs were never executed in the ADO run:Microsoft.Identity.Web.UI.Test(net8/net9)Sidecar.Tests(net10)OidcIdpSignedAssertionProviderTests(net9)CustomSignedAssertionProviderTests(net9)All four are part of
Microsoft.Identity.Web.slnand are already built by the Build stage's full multi-TFM build, so this just adds them to the unit-testtestAssemblyVer2glob. No new build steps.