Skip to content

Fixes #3470 #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jean-Marc Prieur (jmprieur) merged 4 commits into from
Sep 10, 2025
Merged

Fixes #3470 #3471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f70dca2
Fixes #3470
jmprieur Sep 9, 2025
76fffa2
Fixing typo
jmprieur Sep 9, 2025
7ef6b20
Update Directory.Build.props
jmprieur Sep 9, 2025
3439107
Update changelog for version 3.14.1
jmprieur Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<!--This should be passed from the VSTS build-->
<!-- This needs to be greater than or equal to the validation baseline version -->
<MicrosoftIdentityWebVersion Condition="'$(MicrosoftIdentityWebVersion)' == ''">3.13.2</MicrosoftIdentityWebVersion>
<MicrosoftIdentityWebVersion Condition="'$(MicrosoftIdentityWebVersion)' == ''">3.14.1</MicrosoftIdentityWebVersion>
<!--This will generate AssemblyVersion, AssemblyFileVersion and AssemblyInformationVersion-->
<Version>$(MicrosoftIdentityWebVersion)</Version>

Expand Down
5 changes: 5 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
3.14.1
=======
## Bug fix
- Support client secrets with agent user identities. See [#3470](https://github.com/AzureAD/microsoft-identity-web/issues/3470) for details.

3.14.0
=======
## New features
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.Identity.Web.AgentIdentities/AgentUserIdentityMsalAddIn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ internal static Task OnBeforeUserFicForAgentUserIdentityAsync(
request.BodyParameters["grant_type"] = "user_fic";
request.BodyParameters.Remove("password");

if (request.BodyParameters.TryGetValue("client_secret", out var secret)
&& secret.Equals("default", StringComparison.OrdinalIgnoreCase))
if (request.BodyParameters.TryGetValue("client_secret", out var secret))
{
request.BodyParameters.Remove("client_secret");
}
Expand Down
7 changes: 6 additions & 1 deletion src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,12 @@ public async Task RemoveAccountAsync(
private bool IsInvalidClientCertificateOrSignedAssertionError(MsalServiceException exMsal)
{
return !_retryClientCertificate &&
string.Equals(exMsal.ErrorCode, Constants.InvalidClient, StringComparison.OrdinalIgnoreCase);
string.Equals(exMsal.ErrorCode, Constants.InvalidClient, StringComparison.OrdinalIgnoreCase) &&
!exMsal.ResponseBody.Contains("AADSTS7000215" // No retry when wrong client secret.
#if NET6_0_OR_GREATER
, StringComparison.OrdinalIgnoreCase
#endif
);
}


Expand Down