Skip to content

fix(azpysdk): align changelog bootstrap with pinned Chronus path - #49790

Open
Slai.life (huong8373tt-beep) wants to merge 3 commits into
Azure:mainfrom
huong8373tt-beep:docs/azpysdk-changelog-guide-49703-v2
Open

Slai.life (huong8373tt-beep) wants to merge 3 commits into
Azure:mainfrom
huong8373tt-beep:docs/azpysdk-changelog-guide-49703-v2

Conversation

@huong8373tt-beep

Copy link
Copy Markdown
Contributor

Description

Fixes #49703 and addresses the two review findings on the documentation update.

  • Run automatic Chronus installation in the directory that actually owns the pinned package.json and lockfile: .github/chronus.
  • Resolve azpysdk changelog create from the current package directory when no package argument is provided.
  • Document an explicit package-path example and the supported package-directory shorthand.
  • Add regression coverage for current-directory package detection and the pinned install directory.

AI disclosure: Slai Agent Runtime assisted with investigation, implementation, and testing. The account owner reviewed the changes and is responsible for this submission.

Validation

  • python -m pytest tests/test_changelog_commands.py — 40 passed
  • python -m compileall -q azpysdk/changelog.py tests/test_changelog_commands.py — passed
  • git diff --check — passed

Checklist

  • No breaking changes
  • Documentation updated
  • Tests included
  • Contribution guidelines reviewed

Copilot AI balanced review requested due to automatic review settings November 1, 2026 01:10
@github-actions github-actions Bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution Slai.life (@huong8373tt-beep)! We will review the pull request and get back to you soon.

@azure-pipelines

azure-pipelines Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The documentation does not distinguish package-scoped Chronus output from the repository-wide view, which could cause contributors to overlook pending changes or version bumps in other packages.

1 open issue
What changed in this PR

Aligns the azpysdk changelog workflow with the pinned Chronus installation and updates contributor guidance to address #49703.

Changes:

  • Installs and locates Chronus under .github/chronus.
  • Resolves the current package when no package argument is supplied, with regression coverage.
  • Replaces direct Chronus commands with azpysdk examples and documents changelog generation.
File Description
eng/​tools/​azure-sdk-tools/​tests/​test_changelog_commands.py Tests current-directory resolution and the pinned install directory.
eng/​tools/​azure-sdk-tools/​azpysdk/​changelog.py Corrects the Chronus path and adds current-directory package resolution.
doc/​dev/​changelog_updates.md Documents installation and supported azpysdk changelog commands.

Review effort: Balanced

Comment thread doc/dev/changelog_updates.md Resolved
@huong8373tt-beep
Slai.life (huong8373tt-beep) marked this pull request as ready for review November 3, 2026 01:36
Copilot AI balanced review requested due to automatic review settings November 3, 2026 01:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Chronus bootstrap and changelog workflow updates.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Fix outdated Chronus changelog instructions in doc/dev/changelog_updates.md

2 participants