Skip to content

Remove final from DTO's to support Unit Testing #104

Open

Description

@alfanse

As a dev,
I want to write unit tests that mock the documentClient
so that I can unit test the behaviour of my classes.

Currently this is very hard thanks to the final classes returned by the documentClient.
i.e.

   import com.microsoft.azure.documentdb.*;
   import static org.assertj.core.api.Java6Assertions.assertThat;
   import static org.mockito.Matchers.*;
   import static org.mockito.Mockito.*;

...

    private void givenAResponse(List<Document> response) {
        DocumentClient documentClient = mock(DocumentClient.class);
        FeedResponse feedResponse = mock(FeedResponse.class);
        QueryIterable queryIterable = mock(QueryIterable.class);
        when(documentClient.queryDocuments(
                eq(CONNECTION_LINK),
                any(String.class),
                any(FeedOptions.class)))
            .thenReturn(feedResponse);
        when(feedResponse.getQueryIterable()).thenReturn(queryIterable);
        when(queryIterable.toList()).thenReturn(response);
    }

fails with:

  org.mockito.exceptions.base.MockitoException: 
  Cannot mock/spy class com.microsoft.azure.documentdb.FeedResponse 
  Mockito cannot mock/spy following:
    - final classes

Please can you remove 'final' from: FeedResponse and QueryIterable?

Activity

  1. moderakh commented on Apr 25, 2018

    @moderakh
    Contributor

    Alex (@alfanse) thanks for reporting this. We are planning to drop the final keyword from some of the surface classes to make them unit testable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions