Skip to content

ContainerInvalidSettings when using --pull=always #139

Open

Description

@JulesHuisman

When launching a task with container_run_options='--rm --pull=always --workdir=/app'. The task fails with a ContainerInvalidSettings error. Saying the --pull=always is not valid. Is this behaviour blocked on purpose, or is this a bug?

image

Activity

  1. staer commented on Oct 7, 2022

    @staer
    Contributor

    I just checked the sources and it is indeed not parsed which is generating the error. I will check with the author if this was on purpose. I suspect it may be since when using containers in batch the pull is actually done outside of the "docker run" command. Container pulls happen at the VM level or at the task level when you specify which container to execute in. Batch will pull the container for you prior to invoking the docker run on behalf of your task.

  2. JulesHuisman commented on Oct 7, 2022

    @JulesHuisman
    Author

    Thanks for the quick response! It is probably a bit of a niche use case. As we want to keep one VM running for quicker response times, however this means the docker image could be updated in the meantime. So just to be safe I would like the tasks to always pull the latest image.

  3. staer commented on Oct 7, 2022

    @staer
    Contributor

    Ah ok, this makes sense as the way the implementation currently works is to just check locally for the container image, and if it doesn't exist pull it. Your use case makes sense though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions