Skip to content

Make web editor cross-origin isolation reload reliable #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Auburn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make web editor cross-origin isolation reload reliable #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 35 additions & 12 deletions tools/NodeEditor/resources/emscripten_enable_shared_array_buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,23 +48,46 @@ if(typeof window === 'undefined') {

} else {
(async function() {
// Reload at most once per attempt. The marker rides in the URL fragment: Chrome switches browsing
// context group when COOP starts or stops applying, and across that switch a sessionStorage flag can
// come back stale and history.state is dropped. The URL survives the reload in both directions.
const marker = "#coi-reloaded";
const reloadedBySelf = window.location.hash === marker;
if(reloadedBySelf) {
window.history.replaceState(window.history.state, "", window.location.pathname + window.location.search);
}

if(window.crossOriginIsolated !== false) return;

let registration = await navigator.serviceWorker.register(window.document.currentScript.src).catch(e => console.error("COOP/COEP Service Worker failed to register:", e));
if(registration) {
console.log("COOP/COEP Service Worker registered", registration.scope);
if(!window.isSecureContext || !navigator.serviceWorker) {
console.warn("COOP/COEP Service Worker unavailable: a secure context with service worker support is required.");
return;
}

registration.addEventListener("updatefound", () => {
console.log("Reloading page to make use of updated COOP/COEP Service Worker.");
window.location.reload();
});
const scriptURL = window.document.currentScript.src;
const registration = await navigator.serviceWorker.register(scriptURL).catch(e => console.error("COOP/COEP Service Worker failed to register:", e));
if(!registration) return;
console.log("COOP/COEP Service Worker registered", registration.scope);

// If the registration is active, but it's not controlling the page
if(registration.active && !navigator.serviceWorker.controller) {
console.log("Reloading page to make use of COOP/COEP Service Worker.");
window.location.reload();
}
if(reloadedBySelf) {
console.warn("Still not cross-origin isolated after reloading through the COOP/COEP Service Worker; the browser or embedding page is blocking isolation.");
return;
}

// Wait until this worker (not merely any worker in the registration) is active, so the
// reloaded navigation is served with COOP/COEP.
await new Promise(resolve => {
const check = () => { if(registration.active && registration.active.scriptURL === scriptURL) resolve(); };
const track = worker => worker && worker.addEventListener("statechange", check);
registration.addEventListener("updatefound", () => track(registration.installing));
track(registration.installing);
track(registration.waiting);
check();
});

window.history.replaceState(window.history.state, "", marker);
console.log("Reloading page to make use of COOP/COEP Service Worker.");
window.location.reload();
})();
}

Expand Down
Loading