Repository navigation
Apply domain warp seed offset exactly once - #190
Merged
Merged
Conversation
DomainWarp::GenT added the seed offset and then the Gradient/Simplex Warp() overloads added it again, while the SuperSimplex Warp() overloads never added it, so it was ignored when used through DomainWarpFractal. Apply the offset only inside Warp() for all warp types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The domain warp seed offset was applied inconsistently.
DomainWarp::GenTaddedmSeedOffset, then the Gradient and SimplexWarp()overloads added it again. The SuperSimplexWarp()overloads never added it.DomainWarpFractal*callsWarp()directly, bypassingGenT.Fix
Remove the add from
GenT, and add it to the SuperSimplexWarp()overloads. The offset is now applied exactly once, insideWarp(), for every warp type and whichever way it's used.Output change
Only affects warps with a non-zero Seed Offset:
Testing
DomainWarpFractalProgressive, in 2D, 3D and 4D, on SSE2, SSE4.1, AVX2 and AVX512.