Repository navigation
Attest artifacts - #2647
Merged
Merged
Attest artifacts#2647
Conversation
Attest the SBOM and `lib` files in the NuGet packages.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7329 7329
Branches 1013 1013
=======================================
Hits 7053 7053
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Attest the SBOM and the contents of the NuGet packages after they have been signed.
martincostello
marked this pull request as ready for review
June 16, 2025 15:21
martincostello
enabled auto-merge (squash)
June 16, 2025 15:21
There was a problem hiding this comment.
Pull Request Overview
This PR adds steps to attest the SBOM and library files in the NuGet packages by downloading the SBOM, extracting package contents, and running an attestation action.
- Added
permissionsto allow attestation. - Implemented SBOM download and package extraction in the Windows job.
- Configured
actions/attest-build-provenanceto attest both SBOM andlibfiles.
Comments suppressed due to low confidence (3)
.github/workflows/build.yml:371
- [nitpick] The variable name
$packagesis ambiguous; consider renaming it to something more descriptive like$nupkgFilesto clarify that it contains file paths.
$packages = Get-ChildItem -Filter "*.nupkg" | ForEach-Object { $_.FullName }
.github/workflows/build.yml:372
- Consider explicitly creating the root
artifactsdirectory (e.g.,New-Item -ItemType Directory -Path $artifactsPath) before extracting packages, to avoid errors if the SBOM download step fails.
$artifactsPath = Join-Path ${env:GITHUB_WORKSPACE} "artifacts"
.github/workflows/build.yml:390
- The glob pattern
./artifacts/*/lib/**/*may match directories as well as files; consider specifying file extensions (e.g.,./artifacts/*/lib/**/*.dll) or adjusting the pattern to only include the intended artifact files.
./artifacts/*/lib/**/*
Member
Author
|
Verified using the Polly 8.6.1 release by:
|
This was referenced Jul 22, 2025
This was referenced Jul 29, 2025
This was referenced Sep 23, 2026
This was referenced Oct 9, 2026
This was referenced Oct 18, 2026
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attest the SBOM and
libfiles in the NuGet packages.