Skip to content

[PWGCF] Add custom event selection to energyFlowGfw.cxx - #18371

Merged
EmilGorm merged 3 commits into
AliceO2Group:masterfrom
EmilGorm:event-sel-no-zdc
Oct 21, 2026
Merged

[PWGCF] Add custom event selection to energyFlowGfw.cxx#18371
EmilGorm merged 3 commits into
AliceO2Group:masterfrom
EmilGorm:event-sel-no-zdc

Conversation

@EmilGorm

@EmilGorm EmilGorm commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgcf label Oct 20, 2026
@github-actions github-actions Bot changed the title Add custom event selection to energyFlowGfw.cxx [PWGCF] Add custom event selection to energyFlowGfw.cxx Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 8 warnings, 🔕 0 disabled

@EmilGorm
EmilGorm marked this pull request as ready for review October 20, 2026 18:26
@EmilGorm
EmilGorm enabled auto-merge (squash) October 20, 2026 18:31
alibuild
alibuild previously approved these changes Oct 20, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @EmilGorm.

@alibuild

alibuild commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ae4253f at 2026-10-20 20:42:

## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for ae4253f at 2026-10-20 20:46:

## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for ae4253f at 2026-10-20 21:30:

## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft October 20, 2026 19:45
auto-merge was automatically disabled October 20, 2026 19:45

Pull request was converted to draft

@vkucera

vkucera commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Hi @EmilGorm , your PR does not compile on any platform. How did you test it?

@EmilGorm

EmilGorm commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @EmilGorm , your PR does not compile on any platform. How did you test it?

I only ran a compile check for the modified file, but I see now that there is a linker error that I hadn't caught. I fixed that now, and am checking the full O2Physics compilation before repushing.

@EmilGorm
EmilGorm marked this pull request as ready for review October 21, 2026 05:43
@EmilGorm
EmilGorm enabled auto-merge (squash) October 21, 2026 11:57
alibuild
alibuild approved these changes Oct 21, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @EmilGorm.

@EmilGorm
EmilGorm merged commit dc12526 into AliceO2Group:master Oct 21, 2026
15 checks passed
@EmilGorm
EmilGorm deleted the event-sel-no-zdc branch October 21, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner
@wenyaCern wenyaCern Awaiting requested review from wenyaCern wenyaCern is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice dsarkaralice is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EmilGorm @alibuild @vkucera