Repository navigation
Skip combined device creation for empty spec list in DigitizerWorkflow - #15935
Open
jackal1-66 wants to merge 1 commit into
Open
jackal1-66 wants to merge 1 commit into
jackal1-66 wants to merge 1 commit into
Conversation
With --combine-devices, specCombiner() is called unconditionally for digitizerSpecs and for writerSpecs, but when a collection is empty the result is a combined device with no sub-tasks: DPL sees a device with no inputs, injects a Lifetime::Enumeration input (WorkflowHelpers.cxx) and can elect it as the CCDB/DISTSUBTIMEFRAME source. No digits are produced, and since the enumeration is unbounded there is no EOS either, meaning that the workflow hangs forever instead of failing. This is reached with --onlyDet FT0,CTP, where the FT0 digitizer and the CTP digitizer are pushed to specs directly and only the FT0 digit writer goes to writerSpecs, leaving digitizerSpecs empty. In anchored MC that is the detector group of any run taken without both FV0 and EMCAL, such as run 537401, where the problem was found.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --combine-devices, specCombiner() is called unconditionally for digitizerSpecs and for writerSpecs, but when a collection is empty the result is a combined device with no sub-tasks: DPL sees a device with no inputs,
injects a Lifetime::Enumeration input (WorkflowHelpers.cxx) and can elect it as the CCDB/DISTSUBTIMEFRAME source.
No digits are produced, and since the enumeration is unbounded there is no EOS either, meaning that the workflow hangs forever instead of failing. This is reached with --onlyDet FT0,CTP, where the FT0 digitizer and the CTP digitizer are pushed to specs directly and only the FT0 digit writer goes to writerSpecs, leaving digitizerSpecs empty. In anchored MC that is the
detector group of any run taken without both FV0 and EMCAL, such as run 537401, where the problem was found.
This solves the problem reported in O2-5304 by @mbroz84