Repository navigation
Add editorconfig for code style consistency. Format gradle files base… - #381
Conversation
jijisv
left a comment
jijisv
left a comment
There was a problem hiding this comment.
2 space indention - is this only for the gradle files or are we going to use the same for java files as well?
| sudo: true | ||
| language: java | ||
| install: gradle clean | ||
| install: ./gradlew clean |
There was a problem hiding this comment.
this is causing build failures in travis
There was a problem hiding this comment.
My mistake, I didn't realize the .gitignore was excluding all jar files.
The reason of this change is that the current pipeline is wrong. The code specifies gradle version 2.3, but using gradle command it uses whichever version is installed into the travis container (4.X). So that produces a mismatch, and therefore possible building issues.
I excluded the gradle-wrapper.jar from the ignored list and now everything runs properly.
|
@jijisv I started with the gradle files as first step. The idea, if everybody agrees, could be to do a PR formatting properly all lines of code, where code shows full consistency. |
|
Hey @jijisv or @johnmcclean any chance to take a look to this? Thanks. |
…es. Add gradle wrapper.
…o misc/editorconfig
|
@jijisv or @johnmcclean I don't have privileges to merge the branch, so please, could you merge it? Thanks |
…orconfig # Conflicts: # build.gradle # micro-async-data-loader/build.gradle # micro-async-data-writer/build.gradle # micro-core/build.gradle # micro-guava/build.gradle # micro-jmx-metrics/build.gradle # micro-reactive/build.gradle # micro-s3/build.gradle
…eal with conflicts.
Code Changes: