Skip to content

Python: accept nanosecond timestamps in generated parse_rfc3339 #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebxt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Python: accept nanosecond timestamps in generated parse_rfc3339 #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/data/tests/test_custom_serialize_deserialize_functions/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ def parse_rfc3339(date_str: str) -> datetime:
"%Y-%m-%dT%H:%M:%SZ",
"%Y-%m-%dT%H:%M:%S.%fZ"
]

# %f accepts at most 6 fractional digits, but Rust can emit up to 9 (nanoseconds)
head, dot, fraction = date_str.partition(".")
if dot and fraction.endswith("Z"):
date_str = f"{head}.{fraction[:-1][:6]}Z"

for fmt in date_formats:
try:
Expand Down
5 changes: 5 additions & 0 deletions core/data/tests/test_serde_iso8601/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ def parse_rfc3339(date_str: str) -> datetime:
"%Y-%m-%dT%H:%M:%SZ",
"%Y-%m-%dT%H:%M:%S.%fZ"
]

# %f accepts at most 6 fractional digits, but Rust can emit up to 9 (nanoseconds)
head, dot, fraction = date_str.partition(".")
if dot and fraction.endswith("Z"):
date_str = f"{head}.{fraction[:-1][:6]}Z"

for fmt in date_formats:
try:
Expand Down
5 changes: 5 additions & 0 deletions core/src/language/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,11 @@ fn json_translation_for_type(python_type: &str) -> Option<CustomJsonTranslationF
"%Y-%m-%dT%H:%M:%SZ",
"%Y-%m-%dT%H:%M:%S.%fZ"
]

# %f accepts at most 6 fractional digits, but Rust can emit up to 9 (nanoseconds)
head, dot, fraction = date_str.partition(".")
if dot and fraction.endswith("Z"):
date_str = f"{head}.{fraction[:-1][:6]}Z"

for fmt in date_formats:
try:
Expand Down