Repository navigation
Add importer and provisioner test helpers - #34
Merged
Merged
Conversation
florisvdg
changed the title
volodymyrZotov
approved these changes
Nov 18, 2022
Marton6
reviewed
Nov 18, 2022
Marton6
left a comment
Marton6
left a comment
Member
There was a problem hiding this comment.
One important comment and a small suggestion. Otherwise it looks good. I really like the simple signatures of the test helpers!
Marton6
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test helpers for testing importers:
plugintest.TestImporter(t, importer, cases)which runs the cases one by one and sets up the test environment for each case.plugintest.TestProvisioner(t, provisioner, cases)which runs the cases one by one based on the item fields specified.plugintest.LoadFixture(fixtureName)which loads the given test fixture from the plugin'stest-fixturesdirectory.The goal is to make barrier for adding importer tests as low as possible.
To see how these work in action, I'm using the helpers in tests for GitLab, Okta, and Heroku.
Depends on #33