Repository navigation
Conversation
Workers Cache reports a refused purge, such as one over the purge rate limit, as `success: false` in the result of `cache.purge()`. The provider discarded that result, so `cache.invalidate()` resolved although nothing was purged. Throw instead, with the returned `errors` as the error's cause.
🦋 Changeset detectedLatest commit: 96e055f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
success: falsein the result ofcache.purge()(docs). The provider dropped that result, socache.invalidate()resolved and the pages stayed cached with nothing logged. Workers Cache purges always use the Free-tier limit of 5 per minute per account, with a bucket of 25 (limits), which a site that purges on every content save can reach.successisfalse, with Cloudflare'serrorsas the error'scause, asinvalidate()already does on Netlify when its purge request fails. Successful purges are unchanged. Callers that awaitinvalidate()after a write start seeing rejections; EmDash is guarding its calls in fix(core): stop a failed cache purge from failing a saved write emdash-cms/emdash#3987.Testing
test/units/cache-purge.test.tscovers the purge step with a stand-incacheobject, sincecloudflare:workersdoes not load in Node: an accepted purge passes the tags through and resolves, a refused one rejects with the returned errors ascause.Docs
invalidate()does when a purge fails, for any provider.