Skip to content

Added locale initialization from environment variables LC_ALL or LANG - #59

Merged
pesse merged 3 commits into
developfrom
bugfix/nls_from_environment
Jan 16, 2018
Merged

pesse merged 3 commits into
developfrom
bugfix/nls_from_environment

Conversation

@pesse

@pesse pesse commented Jan 15, 2018

Copy link
Copy Markdown
Member

Fixes #56

@jgebal jgebal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance to build a test to verify that NLS session parameters are by those environment parameters?

@pesse

pesse commented Jan 16, 2018 •

Copy link
Copy Markdown
Member Author

Hm, there is the possibility to check whether java-locale matches with NLS session parameters - but that would be testing JDBC driver, which is IMHO out of scope. All I did was setting java locale depending on environment variables.
A real system-test would be nice where you test running utPLSQL-cli in an environment with specific env variables and check for NLS session parameters then, but atm I don't have an idea how that could be achieved in a useful way.

Edit: I'll have a look at the failsafe-plugin for maven which allows integration tests. Might be what I'm actually looking for...

@pesse
pesse merged commit 5a54402 into develop Jan 16, 2018
@pesse
pesse deleted the bugfix/nls_from_environment branch January 16, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants