You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When adressing this, please also consider being able to configure non-string matrix values.
A 2.5 float matrix value is different from a '2.5' string matrix value.
And more importantly, a 3.0 float matrix value is different from a '3.0' string matrix value.
If you give the latter to somewhere else using ${{ matrix.variant }}, you get 3.0 given, if you give the former, you get 3 given as it is parsed and used as number.
@tangdev-w3 it's on hold until client-side binding generation (reducing operational effort of maintaining this library) is done.
It's also pretty tricky to implement elegantly and type-safely, which is another reason I just haven't done it yet. Open for suggestions, PoCs and any other contributions.
Activity
Try to design a StrategyMatrix API #368
[#368] design: StrategyMatrix API
jmfayard commentedon Oct 31, 2022
I've started designing this but I have an outage that prevents me to go further for now
3567714
krzema12 commentedon Jan 17, 2023
Drafting something on my own: http://github.com/krzema12/github-workflows-kt/tree/368-add-matrix-support
krzema12 commentedon Mar 23, 2023
@jmfayard do you plan to work on this? I'm asking because you're still assigned here.
Vampire commentedon Mar 23, 2023
You closed his PR and deleted his branch in January, saying you are drafting it yourself, so, ... :-D
krzema12 commentedon Mar 23, 2023
Ok, so I'm deprioritizing it for v1, to be able to release a "good enough" stable version faster.
Vampire commentedon Apr 19, 2023
When adressing this, please also consider being able to configure non-string matrix values.
A
2.5float matrix value is different from a'2.5'string matrix value.And more importantly, a
3.0float matrix value is different from a'3.0'string matrix value.If you give the latter to somewhere else using
${{ matrix.variant }}, you get3.0given, if you give the former, you get3given as it is parsed and used as number.tangdev-w3 commentedon Nov 7, 2023
just curious if there have been any updates regarding the priority of this?
krzema12 commentedon Nov 7, 2023
@tangdev-w3 it's on hold until client-side binding generation (reducing operational effort of maintaining this library) is done.
It's also pretty tricky to implement elegantly and type-safely, which is another reason I just haven't done it yet. Open for suggestions, PoCs and any other contributions.
krzema12 commentedon Nov 7, 2023
@tangdev-w3 could you share your exact use case? It will be helpful when deciding on the scope of support to be added.
Use Kotlin DSL for benchmark workflow (#221)