Skip to content

[Core feature request] Model matrix context #368

Open

Description

@Vampire

What feature do you need?
https://docs.github.com/en/actions/learn-github-actions/contexts#matrix-context

Also look at related feature requests: #287 and #297.

Do you have an example usage?

name: Test "${{ matrix.distribution.label }}" distribution on ${{ matrix.environment }}
runs-on: ${{ matrix.environment }}
with:
    distribution: ${{ matrix.distribution.user-id }}

Is there a workaround for not having this feature? If yes, please describe it.

name = """Test "${expr("matrix.distribution.label")}" distribution on ${expr("matrix.environment")}"""
runsOn = Custom(expr("matrix.environment"))
distribution = Distribution.Custom(expr("matrix.distribution.user-id"))

Activity

  1. added this to the v1 (stable) milestone on Sep 28, 2022
  2. added 2 commits that reference this issue on Oct 30, 2022
  3. jmfayard commented on Oct 31, 2022

    @jmfayard
    Contributor

    I've started designing this but I have an outage that prevents me to go further for now

    3567714

  4. krzema12 commented on Jan 17, 2023

    @krzema12
    Member
  5. krzema12 commented on Mar 23, 2023

    @krzema12
    Member

    @jmfayard do you plan to work on this? I'm asking because you're still assigned here.

  6. Vampire commented on Mar 23, 2023

    @Vampire
    CollaboratorAuthor

    You closed his PR and deleted his branch in January, saying you are drafting it yourself, so, ... :-D

  7. removed this from the v1 (stable) milestone on Mar 23, 2023
  8. krzema12 commented on Mar 23, 2023

    @krzema12
    Member

    Ok, so I'm deprioritizing it for v1, to be able to release a "good enough" stable version faster.

  9. Vampire commented on Apr 19, 2023

    @Vampire
    CollaboratorAuthor

    When adressing this, please also consider being able to configure non-string matrix values.
    A 2.5 float matrix value is different from a '2.5' string matrix value.
    And more importantly, a 3.0 float matrix value is different from a '3.0' string matrix value.
    If you give the latter to somewhere else using ${{ matrix.variant }}, you get 3.0 given, if you give the former, you get 3 given as it is parsed and used as number.

  10. tangdev-w3 commented on Nov 7, 2023

    @tangdev-w3

    just curious if there have been any updates regarding the priority of this?

  11. krzema12 commented on Nov 7, 2023

    @krzema12
    Member

    @tangdev-w3 it's on hold until client-side binding generation (reducing operational effort of maintaining this library) is done.

    It's also pretty tricky to implement elegantly and type-safely, which is another reason I just haven't done it yet. Open for suggestions, PoCs and any other contributions.

  12. krzema12 commented on Nov 7, 2023

    @krzema12
    Member

    @tangdev-w3 could you share your exact use case? It will be helpful when deciding on the scope of support to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions