Repository navigation
Conversation
If the carousel has indicators but none of them has the `.active` class, sliding threw a TypeError because the current indicator was assumed to exist. Skip the reset when there is no active indicator so the new one still gets marked as active. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RCK6vggtNiub9nuny85at8
julien-deramond
added
js
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Najeeb · project thread
Description
Carousel#_setActiveIndicatorElement()assumed one indicator always has the.activeclass. If a carousel has indicators but none is marked active, sliding throwsTypeError: Cannot read properties of null (reading 'classList')and the new indicator never becomes active.This change skips the reset when no indicator is active, so the new indicator is still marked active.
Motivation & Context
Markup where no indicator starts as active (for example when the active slide is set server side but the indicators are not) breaks the carousel on the first slide change. The fix makes the carousel tolerate that markup instead of throwing.
Type of changes
Checklist
npm run lint)The new test fails on
mainwith the TypeError above and passes with this change.npm run js-test-karma: 810 of 810 pass.