Repository navigation
Add counter for unaccessed failed promise warnings - #3141
Open
yeomin4242 wants to merge 1 commit into
Open
yeomin4242 wants to merge 1 commit into
yeomin4242 wants to merge 1 commit into
Conversation
yeomin4242
marked this pull request as ready for review
October 11, 2026 14:28
Contributor
|
Thank you for the contribution, Just to be transparent we have not decided if we even want #2538 , how we want to support it and how it would effect other SDKs. These are things we need to discuss first before we would review this particular PR so we may not be able to review this PR immediately. Is this a feature you would personally want or did you just want to contribute to the Java SDK? |
Author
|
Thanks for clarifying. I mainly wanted to contribute to the Java SDK and don’t have a specific production use case for this. I’ll keep the PR while the team decides how to approach this across SDKs. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add
temporal_workflow_unaccessed_failed_promise, incremented once for each failed Promise reported by the existing unaccessed-promise warning during runner cleanup. Document the metric and add a changelog entry.The counter follows the existing warning path, including cache eviction and Worker shutdown. Replay-time increments are suppressed by the existing metrics scope; another runner may report the same failure again.
Closes #2538.